Skip to content

[ISSUE #9741] Optimize authentication whitelist lookup efficiency #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #9741] Optimize authentication whitelist lookup efficiency #9742

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
785c012
[ISSUE #9741] Optimize authentication whitelist lookup efficiency
yx9o Sep 28, 2025
374ac5f
Update attribute name
yx9o Oct 10, 2025
3e4001b
Merge branch 'refs/heads/develop' into dev-9741
yx9o Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...java/org/apache/rocketmq/auth/authentication/strategy/AbstractAuthenticationStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
*/
package org.apache.rocketmq.auth.authentication.strategy;

import java.util.ArrayList;
import java.util.List;
import java.util.HashSet;
import java.util.Set;
import java.util.function.Supplier;
import org.apache.commons.lang3.StringUtils;
import org.apache.rocketmq.auth.authentication.context.AuthenticationContext;
Expand All @@ -30,7 +30,7 @@
public abstract class AbstractAuthenticationStrategy implements AuthenticationStrategy {

protected final AuthConfig authConfig;
protected final List<String> authenticationWhitelist = new ArrayList<>();
protected final Set<String> authenticationWhiteSet = new HashSet<>();
protected final AuthenticationProvider<AuthenticationContext> authenticationProvider;

public AbstractAuthenticationStrategy(AuthConfig authConfig, Supplier<?> metadataService) {
Expand All @@ -42,7 +42,7 @@ public AbstractAuthenticationStrategy(AuthConfig authConfig, Supplier<?> metadat
if (StringUtils.isNotBlank(authConfig.getAuthenticationWhitelist())) {
String[] whitelist = StringUtils.split(authConfig.getAuthenticationWhitelist(), ",");
for (String rpcCode : whitelist) {
this.authenticationWhitelist.add(StringUtils.trim(rpcCode));
this.authenticationWhiteSet.add(StringUtils.trim(rpcCode));
}
}
}
Expand All @@ -57,7 +57,7 @@ protected void doEvaluate(AuthenticationContext context) {
if (this.authenticationProvider == null) {
return;
}
if (this.authenticationWhitelist.contains(context.getRpcCode())) {
if (this.authenticationWhiteSet.contains(context.getRpcCode())) {
return;
}
try {
Expand Down
Loading