[ISSUE #9741] Optimize authentication whitelist lookup efficiency #9742
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
previously approved these changes
Oct 10, 2025
lizhimins
reviewed
Oct 10, 2025
|
|
||
| protected final AuthConfig authConfig; | ||
| protected final List<String> authenticationWhitelist = new ArrayList<>(); | ||
| protected final Set<String> authenticationWhitelist = new HashSet<>(); |
There was a problem hiding this comment.
suggest rename it to authenticationWhiteSet
There was a problem hiding this comment.
Completed, please review again, thank you.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9742 +/- ##
=============================================
- Coverage 48.36% 48.24% -0.12%
+ Complexity 12202 12170 -32
=============================================
Files 1313 1313
Lines 93340 93340
Branches 11962 11962
=============================================
- Hits 45140 45029 -111
- Misses 42629 42726 +97
- Partials 5571 5585 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9741 .