Skip to content

Conversation

@ifplusor
Copy link
Contributor

@ifplusor ifplusor commented Apr 16, 2019

What is the purpose of the change

[ISSUE #134 ]Fixed ResponseFuture leak when invokeHeartBeat is failed.

Brief changelog

delete ResponseFuture when invokeHeartBeat is failed.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@jonnxu
Copy link
Contributor

jonnxu commented Apr 17, 2019

good, review ok

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing added the bug Something isn't working label Apr 17, 2019
@ShannonDing ShannonDing added this to the 1.2.2 milestone Apr 17, 2019
@ifplusor ifplusor changed the title [ISSUE 134] Fixed ResponseFuture leak when invokeHeartBeat is failed. [ISSUE #134] Fixed ResponseFuture leak when invokeHeartBeat is failed. Apr 17, 2019
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict fixed. LGTM.

@ShannonDing ShannonDing merged commit 68b323d into apache:master Apr 17, 2019
@ifplusor ifplusor deleted the fixed-invokeHeartBeat branch April 17, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants