Skip to content

Commit 68b323d

Browse files
ifplusorShannonDing
authored andcommitted
[ISSUE #134]Fixed ResponseFuture leak when invokeHeartBeat is failed. (#135)
1 parent 28c4cf0 commit 68b323d

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/transport/TcpRemotingClient.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,14 @@ bool TcpRemotingClient::invokeHeartBeat(const string& addr, RemotingCommand& req
142142
unique_ptr<RemotingCommand> pRsp(responseFuture->waitResponse(3000));
143143
if (pRsp == NULL) {
144144
LOG_ERROR("wait response timeout of heartbeat, so closeTransport of addr:%s", addr.c_str());
145+
findAndDeleteResponseFuture(opaque);
145146
CloseTransport(addr, pTcp);
146147
return false;
147148
} else if (pRsp->getCode() == SUCCESS_VALUE) {
148149
return true;
149150
} else {
150151
LOG_WARN("get error response:%d of heartbeat to addr:%s", pRsp->getCode(), addr.c_str());
152+
findAndDeleteResponseFuture(opaque);
151153
return false;
152154
}
153155
} else {

0 commit comments

Comments
 (0)