Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add doc on how to configure max subscriptions per topic at the topic level #9748

Merged
merged 5 commits into from
Mar 5, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add set-max-subscriptions for topic level
  • Loading branch information
Jennifer88huang-zz committed Feb 27, 2021
commit 14aead617660a446ac961c96f4a57f187e074c00
27 changes: 27 additions & 0 deletions site2/docs/reference-pulsar-admin.md
Original file line number Diff line number Diff line change
Expand Up @@ -1852,6 +1852,9 @@ Subcommands
* `get-inactive-topic-policies`
* `set-inactive-topic-policies`
* `remove-inactive-topic-policies`
* `set-max-subscriptions`
* `get-max-subscriptions`
* `remove-max-subscriptions`
Comment on lines +1855 to +1857
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add them to pulsar-admin website? or is set-max-subscriptions same to set-max-subscriptions-per-topic? Same comments for the other two commands.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set-max-subscriptions is the same to set-max-subscriptions-per-topic, fixed in PR #9750


### `compact`
Run compaction on the specified topic (persistent topics only)
Expand Down Expand Up @@ -2383,6 +2386,30 @@ Usage
$ pulsar-admin topics remove-deduplication tenant/namespace/topic
```

### `set-max-subscriptions`
Set the maximum number of subscriptions for a topic.

Usage
```bash
$ pulsar-admin topics set-max-subscriptions tenant/namespace/topic options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I have some questions:
What does tenant/namespace/topic mean?

If we use this command,a topic name should be passed in here, such as:
persistent://tenant/namespace/topic

The entire command looks like this:
pulsar-admin topics set-max-subscriptions [topic name] [options]

```

### `get-max-subscriptions`
Get the maximum number of subscriptions for a topic.

Usage
```bash
$ pulsar-admin topics get-max-subscriptions tenant/namespace/topic
```

### `remove-max-subscriptions`
Remove the maximum number of subscriptions for a topic.

Usage
```bash
$ pulsar-admin topics remove-max-subscriptions tenant/namespace/topic
```

## `tenants`
Operations for managing tenants

Expand Down