-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Add doc on how to configure max subscriptions per topic at the topic level #9748
Conversation
@315157973 we might need to add related options for |
site2/docs/reference-pulsar-admin.md
Outdated
|
||
Usage | ||
```bash | ||
$ pulsar-admin topics set-max-subscriptions tenant/namespace/topic options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but I have some questions:
What does tenant/namespace/topic
mean?
If we use this command,a topic name should be passed in here, such as:
persistent://tenant/namespace/topic
The entire command looks like this:
pulsar-admin topics set-max-subscriptions [topic name] [options]
Now this command is also called |
Here is the PR #9750 |
* `set-max-subscriptions` | ||
* `get-max-subscriptions` | ||
* `remove-max-subscriptions` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add them to pulsar-admin website? or is set-max-subscriptions
same to set-max-subscriptions-per-topic
? Same comments for the other two commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set-max-subscriptions
is the same to set-max-subscriptions-per-topic
, fixed in PR #9750
@315157973 @Anonymitaet updated, PTAL again, thank you. |
@315157973 @codelipenghui if there is no further issue, could you approve and merge it? If you have any concern, feel free to comment. Thank you. |
…topic level (apache#9748) * add set-max-subscriptions for topic level * update * add set-max-subscription for topic level * update * update
Master Issue: #8866
Related PR: #8948
Motivation
In #8948, we support configuring max subscriptions at topic level.
Modifications