Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] PIP-342: OTel client metrics support #22179

Merged
merged 26 commits into from
Mar 28, 2024

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Mar 3, 2024

PIP: #22178

Motivation

Modifications

(Tests are still missing)

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added the type/feature The PR added a new feature or issue requested a new feature label Mar 3, 2024
@merlimat merlimat added this to the 3.3.0 milestone Mar 3, 2024
@merlimat merlimat self-assigned this Mar 3, 2024
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Mar 3, 2024
@merlimat
Copy link
Contributor Author

merlimat commented Mar 6, 2024

@asafm I applied most of the suggestion, please give it another pass

@merlimat merlimat marked this pull request as ready for review March 6, 2024 21:49
@merlimat merlimat changed the title WIP: PIP-342: OTel client metrics support [improve] WIP: PIP-342: OTel client metrics support Mar 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.08434% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 73.64%. Comparing base (bbc6224) to head (980bae3).
Report is 48 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22179      +/-   ##
============================================
+ Coverage     73.57%   73.64%   +0.07%     
- Complexity    32624    32783     +159     
============================================
  Files          1877     1885       +8     
  Lines        139502   140057     +555     
  Branches      15299    15352      +53     
============================================
+ Hits         102638   103151     +513     
- Misses        28908    28930      +22     
- Partials       7956     7976      +20     
Flag Coverage Δ
inttests 26.76% <60.96%> (+2.17%) ⬆️
systests 24.62% <54.93%> (+0.30%) ⬆️
unittests 72.89% <91.08%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...va/org/apache/pulsar/client/api/ConsumerStats.java 0.00% <ø> (ø)
...va/org/apache/pulsar/client/api/ProducerStats.java 0.00% <ø> (ø)
.../pulsar/client/impl/BatchMessageContainerImpl.java 80.89% <100.00%> (ø)
...e/pulsar/client/impl/BinaryProtoLookupService.java 84.36% <100.00%> (+1.82%) ⬆️
...g/apache/pulsar/client/impl/ClientBuilderImpl.java 86.16% <100.00%> (+0.17%) ⬆️
.../java/org/apache/pulsar/client/impl/ClientCnx.java 71.98% <100.00%> (+0.20%) ⬆️
.../org/apache/pulsar/client/impl/ConnectionPool.java 76.44% <100.00%> (+1.92%) ⬆️
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 77.96% <100.00%> (+0.39%) ⬆️
...ache/pulsar/client/impl/UnAckedMessageTracker.java 92.06% <100.00%> (+0.46%) ⬆️
...lsar/client/impl/conf/ClientConfigurationData.java 96.72% <100.00%> (+0.02%) ⬆️
... and 11 more

... and 74 files with indirect coverage changes

@merlimat merlimat changed the title [improve] WIP: PIP-342: OTel client metrics support [improve] PIP-342: OTel client metrics support Mar 22, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work @merlimat

Copy link
Contributor

@asafm asafm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@merlimat merlimat merged commit 6b29382 into apache:master Mar 28, 2024
49 of 50 checks passed
@merlimat merlimat deleted the client-otel branch March 28, 2024 16:58
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. ready-to-test type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants