Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fixed many tests of pulsar-proxy are not running #23118

Merged

Conversation

equanz
Copy link
Contributor

@equanz equanz commented Aug 2, 2024

Motivation

In #22179 , io.opentelemetry:opentelemetry-sdk-testing was introduced to pulsar-broker. In #22467 , OpenTelemetryAssertions was used at org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest.

However, test cases that extend org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest is not only pulsar-broker, but also pulsar-proxy and pulsar-testclient. These are not running after #22467 is introduced.

Before modification:

% mvn test -pl pulsar-proxy -Dtest='org.apache.pulsar.proxy.server.ProxyServiceStarterTest'
...
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.pulsar.proxy.server.ProxyServiceStarterTest
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.504 s - in org.apache.pulsar.proxy.server.ProxyServiceStarterTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.512 s
[INFO] Finished at: 2024-08-02T12:12:48+09:00
[INFO] ------------------------------------------------------------------------
[INFO] 0 goals, 0 executed

Modifications

  • Move io.opentelemetry:opentelemetry-sdk-testing from pulsar-broker to parent pom

After modification:

% mvn test -pl pulsar-proxy -Dtest='org.apache.pulsar.proxy.server.ProxyServiceStarterTest'
...
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.pulsar.proxy.server.ProxyServiceStarterTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.199 s - in org.apache.pulsar.proxy.server.ProxyServiceStarterTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  21.533 s
[INFO] Finished at: 2024-08-02T12:10:53+09:00
[INFO] ------------------------------------------------------------------------
[INFO] 0 goals, 0 executed

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: equanz#10

@lhotari lhotari merged commit 6dd7c59 into apache:master Aug 5, 2024
61 of 62 checks passed
@equanz equanz deleted the move_opentelemetry-sdk-testing_to_parent_pom branch August 5, 2024 09:44
lhotari pushed a commit that referenced this pull request Aug 6, 2024
Denovo1998 pushed a commit to Denovo1998/pulsar that referenced this pull request Aug 17, 2024
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants