[fix][fn] fix functions_log4j2.xml delete strategy config #21215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Sep 21, 2023
Codecov Report
@@ Coverage Diff @@
## master #21215 +/- ##
=============================================
+ Coverage 36.75% 73.12% +36.37%
- Complexity 12193 32465 +20272
=============================================
Files 1698 1887 +189
Lines 130430 140826 +10396
Branches 14250 15632 +1382
=============================================
+ Hits 47940 102984 +55044
+ Misses 76167 29671 -46496
- Partials 6323 8171 +1848
Flags with carried forward coverage won't be shown. Click here to find out more. |
Technoboy-
pushed a commit
that referenced
this pull request
Sep 25, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Sep 25, 2023
liangyuanpeng
pushed a commit
to liangyuanpeng/pulsar
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the current function_log4j2.xml deletion policy, the matching rules for log files are incorrect. This will cause log cleaning to fail.
The previous PR [https://github.com//pull/19495] fixed the broker’s log cleaning configuration. But the function’s log configuration file is still wrong.
Modifications
remove "*/" of IfFileName in function_log4j2.xml
Documentation
docdoc-requireddoc-not-neededdoc-complete