[fix][broker]: make log4j2 delete strategy work #19495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19494
Motivation
when we use RollingFile, we found log4j2 delete strategy does not work, because the configuration item
IfFileName: glob: "*/${sys:pulsar.log.file}*log.gz"in log4j2.yaml has wrong dir path, "*/" of IfFileName should be removed to make log4j2 delete strategy work.in the log4j2.yaml :
DefaultRolloverStrategy's IfFileName has different dir path with log fileName, the "*/" of IfFileName in should be removed, when we change it into
glob: "${sys:pulsar.log.file}*log.gz", delete strategy works!Modifications
remove "*/" of IfFileName in log4j2.yaml
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete