Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][proxy] PIP-250: Add proxyVersion to CommandConnect #19618

Merged
merged 6 commits into from
Apr 11, 2023
Merged

[feat][proxy] PIP-250: Add proxyVersion to CommandConnect #19618

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c216607
[feat][proxy] Add proxyVersion to CommandConnect; expose in stats
michaeljmarshall Feb 24, 2023
3aaf292
Merge remote-tracking branch 'upstream/master' into add-proxy-version…
michaeljmarshall Apr 6, 2023
bd8747b
Store proxyVersion when provided; even if blank
michaeljmarshall Apr 6, 2023
c93d8ee
Reject proxy connection when proxyVersion is supplied
michaeljmarshall Apr 6, 2023
4253589
Add tests
michaeljmarshall Apr 11, 2023
232cbb6
Add test annotation
michaeljmarshall Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reject proxy connection when proxyVersion is supplied
  • Loading branch information
@michaeljmarshall
michaeljmarshall committed Apr 6, 2023
commit c93d8ee0dd0cd7b7e8cd1bb6ad7b644ee666b66e
9 changes: 9 additions & 0 deletions pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,15 @@ remoteAddress, protocolVersionToAdvertise, getRemoteEndpointProtocolVersion(),
return;
}

if (connect.hasProxyVersion()) {
if (LOG.isDebugEnabled()) {
LOG.debug("[{}] Client illegally provided proxyVersion.", remoteAddress);
}
state = State.Closing;
writeAndFlushAndClose(Commands.newError(-1, ServerError.NotAllowedError, "Must not provide proxyVersion"));
return;
}

try {
// init authn
this.clientConf = createClientConfiguration();
Expand Down