Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][proxy] PIP-250: Add proxyVersion to CommandConnect #19618

Conversation

michaeljmarshall
Copy link
Member

@michaeljmarshall michaeljmarshall commented Feb 23, 2023

PIP #19623
Relates to #19540

Motivation

In order to get more information about connections, it is helpful for the proxy to supply its version to the broker.

Modifications

  • Add proxy_version field to the CommandConnect protobuf message
  • Update proxy and broker to handle this new field

Verifying this change

New tests are added with this PR.

Does this pull request potentially affect one of the following parts:

  • The binary protocol

This will be submitted as part of a PIP.

Documentation

  • doc-not-needed

Matching PR in forked repository

PR in forked repository: Skipping since this is only a draft.

@michaeljmarshall michaeljmarshall added area/broker area/proxy doc-required Your PR changes impact docs and you will update later. labels Feb 23, 2023
@michaeljmarshall michaeljmarshall added this to the 3.0.0 milestone Feb 23, 2023
@michaeljmarshall michaeljmarshall self-assigned this Feb 23, 2023
@michaeljmarshall
Copy link
Member Author

I plan to submit a PIP for this PR. I'll leave it in draft mode until we have a PIP.

@michaeljmarshall michaeljmarshall force-pushed the add-proxy-version-to-connect-command branch from a670d65 to 4f0fa1d Compare February 24, 2023 03:46
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Mar 27, 2023
@poorbarcode
Copy link
Contributor

poorbarcode commented Apr 10, 2023

Since we will start the RC version of 3.0.0 on 2023-04-11, I will change the label/milestone of PR who have not been merged.

  • The PR of type feature is deferred to 3.1.0
  • The PR of type fix is deferred to 3.0.1

So drag this PR to 3.1.0

@poorbarcode poorbarcode modified the milestones: 3.0.0, 3.1.0 Apr 10, 2023
@github-actions github-actions bot removed the Stale label Apr 11, 2023
@michaeljmarshall michaeljmarshall added doc-not-needed Your PR changes do not impact docs ready-to-test and removed doc-required Your PR changes impact docs and you will update later. labels Apr 11, 2023
@michaeljmarshall michaeljmarshall marked this pull request as ready for review April 11, 2023 05:42
@michaeljmarshall
Copy link
Member Author

/pulsarbot rerun-failure-checks

@michaeljmarshall michaeljmarshall changed the title [feat][proxy] Add proxyVersion to CommandConnect; expose in stats [feat][proxy] PIP-250: Add proxyVersion to CommandConnect Apr 11, 2023
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari closed this Apr 11, 2023
@lhotari lhotari reopened this Apr 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Merging #19618 (232cbb6) into master (32e677d) will increase coverage by 1.39%.
The diff coverage is 64.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19618      +/-   ##
============================================
+ Coverage     71.70%   73.09%   +1.39%     
- Complexity    31368    32187     +819     
============================================
  Files          1848     1865      +17     
  Lines        137151   138886    +1735     
  Branches      15111    15284     +173     
============================================
+ Hits          98338   101521    +3183     
+ Misses        30904    29365    -1539     
- Partials       7909     8000      +91     
Flag Coverage Δ
inttests 24.59% <20.45%> (?)
systests 24.75% <23.25%> (?)
unittests 72.39% <64.77%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sar/broker/authorization/AuthorizationService.java 58.00% <0.00%> (+2.80%) ⬆️
...ker/loadbalance/extensions/BrokerRegistryImpl.java 83.33% <ø> (ø)
...apache/pulsar/proxy/server/DirectProxyHandler.java 73.10% <ø> (-0.09%) ⬇️
...rg/apache/pulsar/proxy/server/ProxyConnection.java 58.40% <0.00%> (+0.40%) ⬆️
...rg/apache/pulsar/broker/web/PulsarWebResource.java 64.61% <50.00%> (+0.67%) ⬆️
...a/org/apache/pulsar/proxy/server/ProxyService.java 79.44% <60.86%> (-0.74%) ⬇️
...va/org/apache/pulsar/broker/service/ServerCnx.java 71.74% <92.00%> (+0.45%) ⬆️
...va/org/apache/pulsar/common/protocol/Commands.java 90.88% <100.00%> (+0.42%) ⬆️
...org/apache/pulsar/proxy/server/ProxyClientCnx.java 51.16% <100.00%> (+1.16%) ⬆️

... and 297 files with indirect coverage changes

@michaeljmarshall michaeljmarshall merged commit 1545396 into apache:master Apr 11, 2023
@michaeljmarshall michaeljmarshall modified the milestones: 3.1.0, 3.0.0 Apr 11, 2023
@michaeljmarshall michaeljmarshall deleted the add-proxy-version-to-connect-command branch April 11, 2023 18:19
@michaeljmarshall michaeljmarshall added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-not-needed Your PR changes do not impact docs labels Apr 20, 2023
@michaeljmarshall
Copy link
Member Author

Docs added here: apache/pulsar-site#531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker area/proxy doc-complete Your PR changes impact docs and the related docs have been already added. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants