-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][proxy] PIP-250: Add proxyVersion to CommandConnect #19618
[feat][proxy] PIP-250: Add proxyVersion to CommandConnect #19618
Conversation
I plan to submit a PIP for this PR. I'll leave it in draft mode until we have a PIP. |
a670d65
to
4f0fa1d
Compare
4f0fa1d
to
c216607
Compare
The pr had no activity for 30 days, mark with Stale label. |
Since we will start the RC version of
So drag this PR to |
/pulsarbot rerun-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #19618 +/- ##
============================================
+ Coverage 71.70% 73.09% +1.39%
- Complexity 31368 32187 +819
============================================
Files 1848 1865 +17
Lines 137151 138886 +1735
Branches 15111 15284 +173
============================================
+ Hits 98338 101521 +3183
+ Misses 30904 29365 -1539
- Partials 7909 8000 +91
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Docs added here: apache/pulsar-site#531 |
PIP #19623
Relates to #19540
Motivation
In order to get more information about connections, it is helpful for the proxy to supply its version to the broker.
Modifications
proxy_version
field to theCommandConnect
protobuf messageVerifying this change
New tests are added with this PR.
Does this pull request potentially affect one of the following parts:
This will be submitted as part of a PIP.
Documentation
doc-not-needed
Matching PR in forked repository
PR in forked repository: Skipping since this is only a draft.