Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][doc] add notes to wireshark scripts README #18563

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

labuladong
Copy link
Contributor

Modifications

As #18439 said, the lua script may crash in the newest Wireshark. So add some notes and tips to README.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 22, 2022
@labuladong
Copy link
Contributor Author

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall this PR close #18439?

wireshark/README.md Outdated Show resolved Hide resolved
@labuladong
Copy link
Contributor Author

Shall this PR close #18439?

No, the issue still exists. This pr only adds some information and tips.

Co-authored-by: tison <wander4096@gmail.com>
wireshark/README.md Outdated Show resolved Hide resolved
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@tisonkun tisonkun requested a review from Anonymitaet November 23, 2022 02:56
@Anonymitaet Anonymitaet merged commit 598ca5d into apache:master Nov 24, 2022
@labuladong labuladong deleted the improve-wireshark branch November 24, 2022 07:42
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants