Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] V4.0.1 wireshark lua script will crash #18439

Open
1 of 2 tasks
labuladong opened this issue Nov 12, 2022 · 5 comments
Open
1 of 2 tasks

[Bug] V4.0.1 wireshark lua script will crash #18439

labuladong opened this issue Nov 12, 2022 · 5 comments
Labels
Stale type/bug The PR fixed a bug or issue reported a bug

Comments

@labuladong
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Version

Master version of Pulsar.

Version 4.0.1 (v4.0.1-0-ge9f3970b1527) of Wireshark.

Minimal reproduce step

#13564 add a lua script to parse Pulsar command, which is great.

I follow the step here.

First I put PulsarApi.proto file to a folder and set protobuf search path in wireshark:

image

Then I copy lua script to plugin folder:

image

Restart wireshark and start a pulsar standalone, I can see ping/pong message on port 6650:

image

Now, I create a producer or consumer to send or consume messages.

What did you expect to see?

Wireshark should parse other protobuf packages just like ping/pong.

What did you see instead?

Wireshark will crash.

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@labuladong labuladong added the type/bug The PR fixed a bug or issue reported a bug label Nov 12, 2022
@labuladong
Copy link
Contributor Author

cc @leizhiyuan

@leizhiyuan
Copy link
Contributor

cc @leizhiyuan

#15029

I fixed some issue, but need someone's review.

you can give a try

but If it is not ok, please upload your pcap file , I will upgrade my wireshark(I use 4.0.0 (v4.0.0-0-g0cbe09cd796b).) and test it again

@labuladong
Copy link
Contributor Author

Thanks, I installed Wireshark V3.6.9, and this issue disappeared. You can try Wireshark 4.0.1 and just create a simple producer, this issue will occur.

@labuladong labuladong changed the title [Bug] wireshark lua script not work [Bug] wireshark lua script will crash Nov 13, 2022
@labuladong labuladong changed the title [Bug] wireshark lua script will crash [Bug] V4.0.1 wireshark lua script will crash Nov 13, 2022
@leizhiyuan
Copy link
Contributor

ok,I will check it ,maybe there has an exception in wireshark 4.0.1 or some api can not used in higher version

@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

No branches or pull requests

2 participants