Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fix CoordinatorService, MetadataStore and MockZooKeeper leaks in tests #15638

Merged
merged 10 commits into from
Jul 13, 2022
Merged

[fix][test] Fix CoordinatorService, MetadataStore and MockZooKeeper leaks in tests #15638

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
59bc823
[fix][tests] Ensure thread pools are disposed after some tests
nicoloboschi May 17, 2022
5cd2170
rebase and fix
nicoloboschi Jul 12, 2022
10882d2
revert
nicoloboschi Jul 12, 2022
12c9148
cleanup
nicoloboschi Jul 12, 2022
f0044b5
style
nicoloboschi Jul 12, 2022
86f0807
fix comments
nicoloboschi Jul 12, 2022
cb2b1fc
fix shutdown
nicoloboschi Jul 12, 2022
6c0dbc8
fix compile
nicoloboschi Jul 12, 2022
9f4f40f
fix
nicoloboschi Jul 12, 2022
bce0056
checksytle
nicoloboschi Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix shutdown
  • Loading branch information
@nicoloboschi
nicoloboschi committed Jul 12, 2022
commit cb2b1fce2a04537984bb8afed055d902e214bedf
6 changes: 4 additions & 2 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,10 @@ private CompletableFuture<Void> addTimeoutHandling(CompletableFuture<Void> futur
Duration.ofMillis(Math.max(1L, getConfiguration().getBrokerShutdownTimeoutMs())),
shutdownExecutor, () -> FutureUtil.createTimeoutException("Timeout in close", getClass(), "close"));
future.handle((v, t) -> {
LOG.info("Shutdown timed out after {} ms", getConfiguration().getBrokerShutdownTimeoutMs());
LOG.info(ThreadDumpUtil.buildThreadDiagnosticString());
if (t != null) {
LOG.info("Shutdown timed out after {} ms", getConfiguration().getBrokerShutdownTimeoutMs());
LOG.info(ThreadDumpUtil.buildThreadDiagnosticString());
}
// shutdown the shutdown executor
shutdownExecutor.shutdownNow();
return null;
Expand Down