-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] Fix CoordinatorService, MetadataStore and MockZooKeeper leaks in tests #15638
[fix][test] Fix CoordinatorService, MetadataStore and MockZooKeeper leaks in tests #15638
Conversation
e16c266
to
bd66618
Compare
Will reopen later to re-run the test. |
/pulsarbot rerun-failure-checks |
280557d
to
86b7d07
Compare
Test failed is not related, I opened an issue: #15676 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
/pulsarbot rerun-failure-checks |
1 similar comment
/pulsarbot rerun-failure-checks |
@nicoloboschi Please rebase this PR. It looks like this could help with these issues which happen in PulsarFunctionTlsTest.tearDown:
This is the 4th most flaky issue currently. |
8006c99
to
cf21267
Compare
The pr had no activity for 30 days, mark with Stale label. |
d63a9b2
to
5cd2170
Compare
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentSubscriptionTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/pulsar/client/api/PulsarMultiListenersWithInternalListenerNameTest.java
Outdated
Show resolved
Hide resolved
pulsar-common/src/main/java/org/apache/pulsar/common/util/GracefulExecutorServicesShutdown.java
Outdated
Show resolved
Hide resolved
@lhotari PTAL |
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
Show resolved
Hide resolved
…eaks in tests (apache#15638) * [fix][tests] Ensure thread pools are disposed after some tests * fix comments
Motivation
There are some tests that occasionally fails with non-sense mockito errors like this one:
After investigating I noticed that MetadataStore threads can still receive notifications even if the current test method is finished. Also other thread pools are not shutdown in the correct way and the test must wait for their terminations in order to avoid mixing up Mockito mocked objects.
Modifications
MockedBookKeeperTestCase
based testsThis is related to past flaky-tests like:
fix #15774
no-need-doc