Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an accurate error message when set autoTopicCreation #14684

Merged
merged 10 commits into from
Mar 17, 2022
Merged

Provide an accurate error message when set autoTopicCreation #14684

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c4eca68
Enhance fault tolerance when set auto topic creation with non-partiti…
mattisonchao Mar 15, 2022
7921416
Fix checkstyle
mattisonchao Mar 15, 2022
0847be6
Revert "Enhance fault tolerance when set auto topic creation with non…
mattisonchao Mar 15, 2022
ed3730d
Change fix to provide an accurate error message.
mattisonchao Mar 15, 2022
641f9ca
Merge branch 'master' into enhance_fault_tolerance
mattisonchao Mar 15, 2022
cd9e5c5
Fix checkstyle
mattisonchao Mar 15, 2022
4a92612
Update pulsar-client-admin-api/src/main/java/org/apache/pulsar/common…
mattisonchao Mar 16, 2022
2ebeecf
Update pulsar-client-admin-api/src/main/java/org/apache/pulsar/common…
mattisonchao Mar 16, 2022
5a2e23f
Update pulsar-client-admin-api/src/main/java/org/apache/pulsar/common…
mattisonchao Mar 16, 2022
4350b52
Update pulsar-client-admin-api/src/main/java/org/apache/pulsar/common…
mattisonchao Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix checkstyle
  • Loading branch information
@mattisonchao
mattisonchao committed Mar 15, 2022
commit 7921416029aa54f092d1682be0c7a43007760d0c
4 changes: 2 additions & 2 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,10 +832,10 @@ protected void internalSetAutoTopicCreation(AsyncResponse asyncResponse,
if (autoTopicCreationOverride != null) {
if (!AutoTopicCreationOverrideImpl.isValidOverride(autoTopicCreationOverride)) {
// To enhance error tolerance, automatic error correction
if(!autoTopicCreationOverride.autoFix()) {
if (!autoTopicCreationOverride.autoFix()) {
throw new RestException(Status.PRECONDITION_FAILED,
"Invalid configuration for autoTopicCreationOverride");
};
}
}
if (maxPartitions > 0 && autoTopicCreationOverride.getDefaultNumPartitions() > maxPartitions) {
throw new RestException(Status.NOT_ACCEPTABLE,
Expand Down