Provide an accurate error message when set autoTopicCreation
#14684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
changed the title
autoTopicCreation
|
/pulsarbot rerun-failure-checks |
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
mattisonchao
changed the title
autoTopicCreation autoTopicCreation
|
/pulsarbot rerun-failure-checks |
Technoboy-
reviewed
Mar 15, 2022
...ar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ValidateResult.java
Outdated
Show resolved
Hide resolved
mattisonchao
commented
Mar 16, 2022
...ar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ValidateResult.java
Outdated
Show resolved
Hide resolved
...ar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ValidateResult.java
Outdated
Show resolved
Hide resolved
…/policies/data/ValidateResult.java
…/policies/data/ValidateResult.java
mattisonchao
commented
Mar 16, 2022
...ar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ValidateResult.java
Outdated
Show resolved
Hide resolved
...ar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ValidateResult.java
Outdated
Show resolved
Hide resolved
…/policies/data/ValidateResult.java
…/policies/data/ValidateResult.java
|
/pulsarbot rerun-failure-checks |
codelipenghui
approved these changes
Mar 16, 2022
Technoboy-
approved these changes
Mar 17, 2022
aparajita89
pushed a commit
to aparajita89/pulsar
that referenced
this pull request
Mar 21, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 5, 2022
…ache#14684) (cherry picked from commit 50a7e50) (cherry picked from commit 365152f)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We mention in the documentation that setting
--num-partitionsis not allowed when the user wants to use thenon-partitionedAutoTopicCreation configuration.But some users ignore this and get errors like:
IMO, it's a bit confusing, not telling the user where they are invalid.
Modifications
Verifying this change
Documentation
no-need-doc