Fix: LockManagerTest.updateValue is flaky #13911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jan 24, 2022
|
/pulsarbot run-failure-checks |
mattisonchao
approved these changes
Jan 24, 2022
hangc0276
approved these changes
Jan 25, 2022
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
Apr 12, 2022
This reverts commit 78827be.
shibd
added a commit
to shibd/pulsar
that referenced
this pull request
Apr 20, 2022
This reverts commit 78827be.
1 task
mattisonchao
pushed a commit
that referenced
this pull request
May 7, 2022
codelipenghui
pushed a commit
that referenced
this pull request
May 20, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 23, 2022
…ache#15235) (cherry picked from commit 306a0a1) (cherry picked from commit c9ca16e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#13663 Flaky-test: org.apache.pulsar.metadata.LockManagerTest.updateValue
The reasons are discussed in detail in this PR(#13725)
This is mainly caused by the callback method of
LocalMemoryMetadataStoreand the concurrent access of the notification thread to theMetadataCache#refresh.This will only reproduce when
MetadataStoreimplemented asLocalMemoryMetadataStore.Modifications
LocalMemoryMetadataStorereturn for future execution in themetadata-storethread poolDocumentation
no-need-doc