Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test testSharedInstance fail #13908

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

shibd
Copy link
Member

@shibd shibd commented Jan 23, 2022

Motivation

#13907

In this unit test, Two MetadataStore do not share a listener. when executed store2.delete, store1 existsCache is not invalidate.

@Test
public void testSharedInstance() throws Exception {
String url = "memory://" + UUID.randomUUID();
@Cleanup
MetadataStore store1 = MetadataStoreFactory.create(url,
MetadataStoreConfig.builder().build());
@Cleanup
MetadataStore store2 = MetadataStoreFactory.create(url,
MetadataStoreConfig.builder().build());

Modifications

  1. Let LocalMemoryMetadataStore instances with the same address register on the same listener

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 23, 2022
@shibd
Copy link
Member Author

shibd commented Jan 23, 2022

/pulsarbot run-failure-checks

2 similar comments
@shibd
Copy link
Member Author

shibd commented Jan 23, 2022

/pulsarbot run-failure-checks

@shibd
Copy link
Member Author

shibd commented Jan 23, 2022

/pulsarbot run-failure-checks

@shibd
Copy link
Member Author

shibd commented Jan 24, 2022

/pulsarbot run-failure-checks

1 similar comment
@shibd
Copy link
Member Author

shibd commented Jan 24, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit b208ab0 into apache:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants