Merged
Conversation
BewareMyPower
approved these changes
Jan 31, 2023
| #include <epan/proto.h> | ||
| #include <epan/value_string.h> | ||
| #include <glib.h> | ||
| #include <ws_version.h> |
Contributor
There was a problem hiding this comment.
This header does not work for the wireshark-dev (3.2.3) on Ubuntu. It seems to be caused by the breaking change of the wireshark.
Anyway, currently we can focus on the wireshark 4.x support. So this comment is not a blocker.
Member
Author
There was a problem hiding this comment.
Yes, we can fix it for old version support later if necessary.
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-cpp
that referenced
this pull request
Jan 31, 2023
### Motivation apache#182 fixes the Wireshark build process on macOS. However, it breaks the compatibility with some Wireshark distributions like the default Wireshark 3.2.3 on Ubuntu 20.04. The reason is some Wireshark distributions use `config.h` to record the versions, while other might use `ws_version.h`. See https://listman.redhat.com/archives/libvir-list/2020-September/msg00377.html for a similar fix. ### Modifications Try to find the `ws_version.h` first, if it's not found, find the `config.h`. To be more user friendly: - Separate the dissector from the whole project so that we can build the dissector without building the Pulsar C++ client. - Refactor the README of the Wireshark dissector by focusing on how to use.
4 tasks
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-cpp
that referenced
this pull request
Jan 31, 2023
### Motivation apache#182 fixes the Wireshark build process on macOS. However, it breaks the compatibility with some Wireshark distributions like the default Wireshark 3.2.3 on Ubuntu 20.04. The reason is some Wireshark distributions use `config.h` to record the versions, while other might use `ws_version.h`. See https://listman.redhat.com/archives/libvir-list/2020-September/msg00377.html for a similar fix. ### Modifications Try to find the `ws_version.h` first, if it's not found, find the `config.h`. Add the workflow to verify it can be built on Ubuntu. To be more user friendly: - Separate the dissector from the whole project so that we can build the dissector without building the Pulsar C++ client. - Refactor the README of the Wireshark dissector by focusing on how to use.
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-cpp
that referenced
this pull request
Jan 31, 2023
### Motivation apache#182 fixes the Wireshark build process on macOS. However, it breaks the compatibility with some Wireshark distributions like the default Wireshark 3.2.3 on Ubuntu 20.04. The reason is some Wireshark distributions use `config.h` to record the versions, while other might use `ws_version.h`. See https://listman.redhat.com/archives/libvir-list/2020-September/msg00377.html for a similar fix. ### Modifications Try to find the `ws_version.h` first, if it's not found, find the `config.h`. Add the workflow to verify it can be built on Ubuntu. To be more user friendly: - Separate the dissector from the whole project so that we can build the dissector without building the Pulsar C++ client. - Refactor the README of the Wireshark dissector by focusing on how to use.
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-cpp
that referenced
this pull request
Feb 2, 2023
### Motivation apache#182 fixes the Wireshark build process on macOS. However, it breaks the compatibility with some Wireshark distributions like the default Wireshark 3.2.3 on Ubuntu 20.04. The reason is some Wireshark distributions use `config.h` to record the versions, while other might use `ws_version.h`. See https://listman.redhat.com/archives/libvir-list/2020-September/msg00377.html for a similar fix. ### Modifications Try to find the `ws_version.h` first, if it's not found, find the `config.h`. Add the workflow to verify it can be built on Ubuntu. To be more user friendly: - Separate the dissector from the whole project so that we can build the dissector without building the Pulsar C++ client. - Refactor the README of the Wireshark dissector by focusing on how to use. ### Verifications Add a workflow to build Wireshark dissector on both Ubuntu and macOS.
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-cpp
that referenced
this pull request
Feb 2, 2023
### Motivation apache#182 fixes the Wireshark build process on macOS. However, it breaks the compatibility with some Wireshark distributions like the default Wireshark 3.2.3 on Ubuntu 20.04. The reason is some Wireshark distributions use `config.h` to record the versions, while other might use `ws_version.h`. See https://listman.redhat.com/archives/libvir-list/2020-September/msg00377.html for a similar fix. ### Modifications Try to find the `ws_version.h` first, if it's not found, find the `config.h`. Add the workflow to verify it can be built on Ubuntu. To be more user friendly: - Separate the dissector from the whole project so that we can build the dissector without building the Pulsar C++ client. - Refactor the README of the Wireshark dissector by focusing on how to use. ### Verifications Add a workflow to build Wireshark dissector on both Ubuntu and macOS.
BewareMyPower
added a commit
that referenced
this pull request
Feb 3, 2023
* Support the Wireshark plugin for more Wireshark distributions ### Motivation #182 fixes the Wireshark build process on macOS. However, it breaks the compatibility with some Wireshark distributions like the default Wireshark 3.2.3 on Ubuntu 20.04. The reason is some Wireshark distributions use `config.h` to record the versions, while other might use `ws_version.h`. See https://listman.redhat.com/archives/libvir-list/2020-September/msg00377.html for a similar fix. ### Modifications Try to find the `ws_version.h` first, if it's not found, find the `config.h`. Add the workflow to verify it can be built on Ubuntu. To be more user friendly: - Separate the dissector from the whole project so that we can build the dissector without building the Pulsar C++ client. - Refactor the README of the Wireshark dissector by focusing on how to use. ### Verifications Add a workflow to build Wireshark dissector on both Ubuntu and macOS.
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 8, 2023
(cherry picked from commit dd649f5)
BewareMyPower
added a commit
that referenced
this pull request
Feb 8, 2023
* Support the Wireshark plugin for more Wireshark distributions ### Motivation #182 fixes the Wireshark build process on macOS. However, it breaks the compatibility with some Wireshark distributions like the default Wireshark 3.2.3 on Ubuntu 20.04. The reason is some Wireshark distributions use `config.h` to record the versions, while other might use `ws_version.h`. See https://listman.redhat.com/archives/libvir-list/2020-September/msg00377.html for a similar fix. ### Modifications Try to find the `ws_version.h` first, if it's not found, find the `config.h`. Add the workflow to verify it can be built on Ubuntu. To be more user friendly: - Separate the dissector from the whole project so that we can build the dissector without building the Pulsar C++ client. - Refactor the README of the Wireshark dissector by focusing on how to use. ### Verifications Add a workflow to build Wireshark dissector on both Ubuntu and macOS. (cherry picked from commit 63c4245)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Pulsar Wireshark plugin has not been maintained for a long time,
the Pulsar protobuf command and Wireshark header file have been updated.
Modifications
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)