Skip to content

[Bug] wireshark build points to wrong pulsar-common directory #179

@lin-zhao

Description

@lin-zhao

Search before asking

  • I searched in the issues and found nothing similar.

Version

3.1.1. Reproduced on M1 macbook pro but it should affect all OS are affected since it's a bad directory link.

Minimal reproduce step

  1. On a M1 macbook, run steps on https://github.com/apache/pulsar-client-cpp to install dependencies.
  2. Run cmake command to prepare wireshark build:
    cmake -DBUILD_WIRESHARK=ON -DGTEST_INCLUDE_PATH=/usr/local/Cellar/googletest/1.13.0/include/gtest -DGMOCK_INCLUDE_PATH=/usr/local/Cellar/googletest/1.13.0/include/gmock .
  3. make pulsar-dissector points to a bad directory for pulsar-common.
make[3]: *** No rule to make target `/Users/lin/git/pulsar-common/src/main/proto/PulsarApi.proto', needed by `generated/lib/PulsarApi.pb.cc'.  Stop.
make[2]: *** [wireshark/CMakeFiles/pulsar-dissector.dir/all] Error 2
make[1]: *** [wireshark/CMakeFiles/pulsar-dissector.dir/rule] Error 2
make: *** [pulsar-dissector] Error 2```

### What did you expect to see?

`make pulsar-dissector` should be successful.

### What did you see instead?

Error message that points to a bad directory for `pulsar-common`.

### Anything else?

This should be caused by the migration from the core pulsar directory. The script need to be updated to point to the right `pulsar-common` source code for `PulsarApi.proto`.

### Are you willing to submit a PR?

- [ ] I'm willing to submit a PR!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions