Remove generated Python client from git tracking #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain,
ebyhr,
ajantha-bhat,
HonahX,
singhpk234 and
pingtimeout
as code owners
HonahX
reviewed
Jun 5, 2025
| @@ -30,14 +30,17 @@ for arg in "$@"; do | |||
| fi | |||
| done | |||
|
|
|||
| # Check if the python client needs regeneration | |||
| if [ "$repair" == true ] || [ ! -f "${dir}/client/python/polaris/catalog/__init__.py" ]; then | |||
| ./gradlew regeneratePythonClient | |||
There was a problem hiding this comment.
The generation will likely fails if user use MacOS, due to the .DS_Store file thing : (.
This is not our fault, but to ensure a smoother installation experiences, shall we consider cleaning the folder before regenerating here or add .DS_Store, poetry.lock to the EXCLUDE_PATHS/EXCLUDE_EXTENSION in the regenerate.sh?
|
We may also need to update the Spark Getting-Started example's Dockerfile to run the polaris/getting-started/spark/notebooks/Dockerfile Lines 24 to 30 in 1655dae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1675, we now generate the Python client on-demand when it's needed by tests or the CLI. With this, we can safely remove the Python client from being tracked in the repo and add its files to .gitignore
Fixes #755