Skip to content

Automate regeneration of Python client #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 4, 2025

Conversation

eric-maynard
Copy link
Contributor

@eric-maynard eric-maynard commented May 24, 2025

When running regtests or the CLI, we should run ./gradlew regeneratePythonClient in order to run against the most up-to-date Python client.

As part of this change, I've also updated the generator to 7.12 to match what's in the libs.version.toml and regenerated the code managed in github.

Once the automatic generation works as part of CI, we can remove the generated code from the repo altogether. In the future, it can be added to .gitignore.

@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board May 24, 2025
eric-maynard added a commit that referenced this pull request Jun 2, 2025
It looks like this method lost the `prefix` and `namespace` parameters in #1347. They're re-introduced to the spec here, and then I've run:
```
redocly bundle spec/polaris-catalog-service.yaml -o spec/generated/bundled-polaris-catalog-service.yaml
./gradlew regeneratePythonClient
```

Then, some manual reverts:
```
alias gitrevert='git checkout upstream/main --'
gitrevert client/python/.github/workflows/python.yml
gitrevert client/python/.gitlab-ci.yml
gitrevert client/python/pyproject.toml
```

I still hope to automate this process as part of CI soon; see #1675
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the auto-generation works!

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jun 4, 2025
@eric-maynard eric-maynard merged commit 3b18e0d into apache:main Jun 4, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants