Skip to content

Adding new ADLSPinotFS auth type: DEFAULT #9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangfu0 merged 1 commit into from
Nov 25, 2022
Merged

Adding new ADLSPinotFS auth type: DEFAULT #9860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions ...e-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public class ADLSGen2PinotFS extends BasePinotFS {
private static final Logger LOGGER = LoggerFactory.getLogger(ADLSGen2PinotFS.class);

private enum AuthenticationType {
ACCESS_KEY, AZURE_AD, AZURE_AD_WITH_PROXY, ANONYMOUS_ACCESS
ACCESS_KEY, AZURE_AD, AZURE_AD_WITH_PROXY, ANONYMOUS_ACCESS, DEFAULT
}

private static final String AUTHENTICATION_TYPE = "authenticationType";
Expand Down Expand Up @@ -189,11 +189,7 @@ public void init(PinotConfiguration config) {
dataLakeServiceClientBuilder.credential(clientSecretCredentialBuilder.build());
break;
}
case ANONYMOUS_ACCESS: {
LOGGER.info("Authenticating using anonymous access");
break;
}
default: {
case DEFAULT: {
LOGGER.info("Authenticating using Azure default credential");
DefaultAzureCredentialBuilder defaultAzureCredentialBuilder = new DefaultAzureCredentialBuilder();
if (tenantId != null) {
Expand All @@ -211,6 +207,14 @@ public void init(PinotConfiguration config) {
dataLakeServiceClientBuilder.credential(defaultAzureCredentialBuilder.build());
break;
}
case ANONYMOUS_ACCESS: {
LOGGER.info("Authenticating using anonymous access");
break;
}
default: {
// Should never reach here
throw new IllegalStateException("Unexpected authType: " + authType);
}
}

DataLakeServiceClient serviceClient = dataLakeServiceClientBuilder.buildClient();
Expand Down