Skip to content

Adding new ADLSPinotFS auth type: DEFAULT#9860

Merged
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:azure-adls-default
Nov 25, 2022
Merged

Adding new ADLSPinotFS auth type: DEFAULT#9860
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:azure-adls-default

Conversation

@xiangfu0
Copy link
Contributor

Release Notes

  • Adding new ADLSPinotFS auth type: DEFAULT

@xiangfu0 xiangfu0 requested a review from snleee November 25, 2022 02:06
@xiangfu0 xiangfu0 added the release-notes Referenced by PRs that need attention when compiling the next release notes label Nov 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #9860 (b9c36b8) into master (0c67329) will decrease coverage by 1.88%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9860      +/-   ##
============================================
- Coverage     70.38%   68.50%   -1.89%     
- Complexity     5013     5456     +443     
============================================
  Files          1972     1972              
  Lines        105687   105687              
  Branches      15988    15988              
============================================
- Hits          74386    72397    -1989     
- Misses        26100    28165    +2065     
+ Partials       5201     5125      -76     
Flag Coverage Δ
integration1 25.10% <ø> (-0.01%) ⬇️
integration2 ?
unittests1 67.73% <ø> (+<0.01%) ⬆️
unittests2 15.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/apache/pinot/server/api/resources/ErrorInfo.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...t/core/plan/StreamingInstanceResponsePlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ore/operator/streaming/StreamingResponseUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...server/starter/helix/SegmentReloadStatusValue.java 0.00% <0.00%> (-100.00%) ⬇️
...ager/realtime/PeerSchemeSplitSegmentCommitter.java 0.00% <0.00%> (-100.00%) ⬇️
...urces/ServerReloadControllerJobStatusResponse.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/utils/grpc/GrpcRequestBuilder.java 0.00% <0.00%> (-90.91%) ⬇️
...ator/streaming/StreamingSelectionOnlyOperator.java 0.00% <0.00%> (-90.00%) ⬇️
...he/pinot/core/plan/StreamingSelectionPlanNode.java 0.00% <0.00%> (-88.89%) ⬇️
... and 152 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snleee
Copy link
Contributor

snleee commented Nov 25, 2022

Please address the issue with the test. Otherwise, LGTM

@xiangfu0
Copy link
Contributor Author

Please address the issue with the test. Otherwise, LGTM

Thanks! I will rerun the tests. Don't see any change introduced by this PR may fail it.

@xiangfu0 xiangfu0 merged commit aa839c9 into apache:master Nov 25, 2022
@xiangfu0 xiangfu0 deleted the azure-adls-default branch November 25, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes Referenced by PRs that need attention when compiling the next release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants