Skip to content

Add capability to update and delete table config via CLI #9852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KKcorps merged 4 commits into from
Dec 7, 2022
Merged

Add capability to update and delete table config via CLI #9852

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abff2f5
Add capability top update and delete table config via CLI
KKcorps Nov 23, 2022
016668d
Add old command for backward compatibility
Nov 25, 2022
f29c6ea
Only use update command
Dec 1, 2022
7357bf4
revert linting
Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ public class AddTableCommand extends AbstractBaseAdminCommand implements Command
@CommandLine.Option(names = {"-controllerProtocol"}, required = false, description = "protocol for controller.")
private String _controllerProtocol = CommonConstants.HTTP_PROTOCOL;

@CommandLine.Option(names = {"-update"}, required = false,
description = "Update the existing table instead of creating new one")
private boolean _update = false;

@CommandLine.Option(names = {"-exec"}, required = false, description = "Execute the command.")
private boolean _exec;

Expand Down Expand Up @@ -191,6 +195,15 @@ public boolean sendTableCreationRequest(JsonNode node)
return res.contains("successfully added");
}

public boolean sendTableUpdateRequest(JsonNode node, String tableName)
throws IOException {
String res = AbstractBaseAdminCommand.sendRequest("PUT",
ControllerRequestURLBuilder.baseUrl(_controllerAddress).forTableConfigsUpdate(tableName), node.toString(),
makeAuthHeaders(makeAuthProvider(_authProvider, _authTokenUrl, _authToken, _user, _password)));
LOGGER.info(res);
return res.contains("TableConfigs updated");
}

@Override
public boolean execute()
throws Exception {
Expand Down Expand Up @@ -239,7 +252,11 @@ public boolean execute()
"Failed reading schema " + _schemaFile);
TableConfigs tableConfigs = new TableConfigs(rawTableName, schema, offlineTableConfig, realtimeTableConfig);

return sendTableCreationRequest(JsonUtils.objectToJsonNode(tableConfigs));
if (_update) {
return sendTableUpdateRequest(tableConfigs.toJsonNode(), rawTableName);
} else {
return sendTableCreationRequest(tableConfigs.toJsonNode());
}
}

private static <T> T attempt(Callable<T> callable, String errorMessage) {
Expand Down