Add capability to update and delete table config via CLI#9852
Merged
KKcorps merged 4 commits intoapache:masterfrom Dec 7, 2022
Merged
Add capability to update and delete table config via CLI#9852KKcorps merged 4 commits intoapache:masterfrom
KKcorps merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9852 +/- ##
============================================
+ Coverage 68.96% 70.44% +1.48%
+ Complexity 5522 5058 -464
============================================
Files 1978 1982 +4
Lines 106182 106449 +267
Branches 16089 16131 +42
============================================
+ Hits 73230 74991 +1761
+ Misses 27820 26220 -1600
- Partials 5132 5238 +106
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KKcorps
changed the title
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
IMO, using ModifyTable to create table is not very intuitive. I'd suggest adding a -update flag in the current AddTableCommand, and add a separate DeleteTableCommand for the table deletion which only takes the table name without config
Contributor
|
#9857 Added the command for table/schema deletion, so let's just add the update flag in this PR |
KKcorps
force-pushed
the
update_table_patch
branch
from
08e8f3b to
f29c6ea
Compare
Jackie-Jiang
approved these changes
Dec 7, 2022
...ation-tests/src/test/java/org/apache/pinot/integration/tests/ChaosMonkeyIntegrationTest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #9840