[multistage] Support IN and NOT-IN Clauses#9374
Conversation
walterddr
left a comment
There was a problem hiding this comment.
could you add some test to validate this?
|
this should be included in #9375 |
|
@walterddr : I was working on the IN/NOT-IN/Range support. Does #9375 take care of that as well? |
Codecov Report
@@ Coverage Diff @@
## master #9374 +/- ##
============================================
+ Coverage 63.40% 68.49% +5.08%
- Complexity 4762 4780 +18
============================================
Files 1832 1886 +54
Lines 98146 100428 +2282
Branches 15020 15282 +262
============================================
+ Hits 62231 68786 +6555
+ Misses 31321 26701 -4620
- Partials 4594 4941 +347
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ah. no that only takes care of the could you add some test cases to validate your change for IN as well? |
walterddr
left a comment
There was a problem hiding this comment.
looks good to me overall with the approach. left a few comments. plz kindly take a look
Related to #9345
Query to verify:
cc: @walterddr