[multistage] Support range queries in search#11512
Merged
xiangfu0 merged 2 commits intoapache:masterfrom Sep 6, 2023
Merged
Conversation
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #11512 +/- ##
============================================
- Coverage 63.03% 63.03% -0.01%
+ Complexity 1109 1108 -1
============================================
Files 2320 2320
Lines 124524 124566 +42
Branches 19011 19019 +8
============================================
+ Hits 78495 78518 +23
- Misses 40436 40456 +20
+ Partials 5593 5592 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
08c2143 to
4f4e67d
Compare
xiangfu0
approved these changes
Sep 5, 2023
4f4e67d to
e98d73f
Compare
walterddr
reviewed
Sep 18, 2023
...t-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpressionUtils.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error I detected while trying to run all integration tests with V2. It seems that some queries are translated in V2 using SqlKind.SEARCH. We added partial support for that when implementing IN (for example in #9374) but that was limited to cases where
SEARCHused literals (like inINexpressions).I've tried to exercise my code with more tests, but I wasn't able to create SQL queries that were translated into SqlKind.SEARCH. Therefore I've just modified the original test to run in both V1 and V2. It seems the kind of queries that are translated into this pattern are things like:
but not queries like: