Skip to content

[Code Refactor] ArrayCopyUtils 2D Array for Transform Functions #9324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddharthteotia merged 3 commits into from
Sep 6, 2022
Merged

[Code Refactor] ArrayCopyUtils 2D Array for Transform Functions #9324

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0a8b40
added 2D array copy
SabrinaZhaozyf Sep 1, 2022
f402407
trigger test
SabrinaZhaozyf Sep 6, 2022
0238bc9
trigger test
SabrinaZhaozyf Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 24 additions & 164 deletions ...rc/main/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,15 +335,11 @@ public String[] transformToStringValuesSV(ProjectionBlock projectionBlock) {
break;
case BOOLEAN:
intValues = transformToIntValuesSV(projectionBlock);
for (int i = 0; i < length; i++) {
_stringValuesSV[i] = Boolean.toString(intValues[i] == 1);
}
ArrayCopyUtils.copyBoolean(intValues, _stringValuesSV, length);
break;
case TIMESTAMP:
longValues = transformToLongValuesSV(projectionBlock);
for (int i = 0; i < length; i++) {
_stringValuesSV[i] = new Timestamp(longValues[i]).toString();
}
ArrayCopyUtils.copyTimestamp(longValues, _stringValuesSV, length);
break;
case BYTES:
byte[][] bytesValues = transformToBytesValuesSV(projectionBlock);
Expand Down Expand Up @@ -399,43 +395,19 @@ public int[][] transformToIntValuesMV(ProjectionBlock projectionBlock) {
switch (getResultMetadata().getDataType().getStoredType()) {
case LONG:
long[][] longValuesMV = transformToLongValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
long[] longValues = longValuesMV[i];
int numValues = longValues.length;
int[] intValues = new int[numValues];
ArrayCopyUtils.copy(longValues, intValues, numValues);
_intValuesMV[i] = intValues;
}
ArrayCopyUtils.copy(longValuesMV, _intValuesMV, length);
break;
case FLOAT:
float[][] floatValuesMV = transformToFloatValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
float[] floatValues = floatValuesMV[i];
int numValues = floatValues.length;
int[] intValues = new int[numValues];
ArrayCopyUtils.copy(floatValues, intValues, numValues);
_intValuesMV[i] = intValues;
}
ArrayCopyUtils.copy(floatValuesMV, _intValuesMV, length);
break;
case DOUBLE:
double[][] doubleValuesMV = transformToDoubleValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
double[] doubleValues = doubleValuesMV[i];
int numValues = doubleValues.length;
int[] intValues = new int[numValues];
ArrayCopyUtils.copy(doubleValues, intValues, numValues);
_intValuesMV[i] = intValues;
}
ArrayCopyUtils.copy(doubleValuesMV, _intValuesMV, length);
break;
case STRING:
String[][] stringValuesMV = transformToStringValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
String[] stringValues = stringValuesMV[i];
int numValues = stringValues.length;
int[] intValues = new int[numValues];
ArrayCopyUtils.copy(stringValues, intValues, numValues);
_intValuesMV[i] = intValues;
}
ArrayCopyUtils.copy(stringValuesMV, _intValuesMV, length);
break;
default:
throw new IllegalStateException();
Expand Down Expand Up @@ -464,43 +436,19 @@ public long[][] transformToLongValuesMV(ProjectionBlock projectionBlock) {
switch (getResultMetadata().getDataType().getStoredType()) {
case INT:
int[][] intValuesMV = transformToIntValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
int[] intValues = intValuesMV[i];
int numValues = intValues.length;
long[] longValues = new long[numValues];
ArrayCopyUtils.copy(intValues, longValues, numValues);
_longValuesMV[i] = longValues;
}
ArrayCopyUtils.copy(intValuesMV, _longValuesMV, length);
break;
case FLOAT:
float[][] floatValuesMV = transformToFloatValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
float[] floatValues = floatValuesMV[i];
int numValues = floatValues.length;
long[] longValues = new long[numValues];
ArrayCopyUtils.copy(floatValues, longValues, numValues);
_longValuesMV[i] = longValues;
}
ArrayCopyUtils.copy(floatValuesMV, _longValuesMV, length);
break;
case DOUBLE:
double[][] doubleValuesMV = transformToDoubleValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
double[] doubleValues = doubleValuesMV[i];
int numValues = doubleValues.length;
long[] longValues = new long[numValues];
ArrayCopyUtils.copy(doubleValues, longValues, numValues);
_longValuesMV[i] = longValues;
}
ArrayCopyUtils.copy(doubleValuesMV, _longValuesMV, length);
break;
case STRING:
String[][] stringValuesMV = transformToStringValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
String[] stringValues = stringValuesMV[i];
int numValues = stringValues.length;
long[] longValues = new long[numValues];
ArrayCopyUtils.copy(stringValues, longValues, numValues);
_longValuesMV[i] = longValues;
}
ArrayCopyUtils.copy(stringValuesMV, _longValuesMV, length);
break;
default:
throw new IllegalStateException();
Expand Down Expand Up @@ -529,43 +477,19 @@ public float[][] transformToFloatValuesMV(ProjectionBlock projectionBlock) {
switch (getResultMetadata().getDataType().getStoredType()) {
case INT:
int[][] intValuesMV = transformToIntValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
int[] intValues = intValuesMV[i];
int numValues = intValues.length;
float[] floatValues = new float[numValues];
ArrayCopyUtils.copy(intValues, floatValues, numValues);
_floatValuesMV[i] = floatValues;
}
ArrayCopyUtils.copy(intValuesMV, _floatValuesMV, length);
break;
case LONG:
long[][] longValuesMV = transformToLongValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
long[] longValues = longValuesMV[i];
int numValues = longValues.length;
float[] floatValues = new float[numValues];
ArrayCopyUtils.copy(longValues, floatValues, numValues);
_floatValuesMV[i] = floatValues;
}
ArrayCopyUtils.copy(longValuesMV, _floatValuesMV, length);
break;
case DOUBLE:
double[][] doubleValuesMV = transformToDoubleValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
double[] doubleValues = doubleValuesMV[i];
int numValues = doubleValues.length;
float[] floatValues = new float[numValues];
ArrayCopyUtils.copy(doubleValues, floatValues, numValues);
_floatValuesMV[i] = floatValues;
}
ArrayCopyUtils.copy(doubleValuesMV, _floatValuesMV, length);
break;
case STRING:
String[][] stringValuesMV = transformToStringValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
String[] stringValues = stringValuesMV[i];
int numValues = stringValues.length;
float[] floatValues = new float[numValues];
ArrayCopyUtils.copy(stringValues, floatValues, numValues);
_floatValuesMV[i] = floatValues;
}
ArrayCopyUtils.copy(stringValuesMV, _floatValuesMV, length);
break;
default:
throw new IllegalStateException();
Expand Down Expand Up @@ -594,43 +518,19 @@ public double[][] transformToDoubleValuesMV(ProjectionBlock projectionBlock) {
switch (getResultMetadata().getDataType().getStoredType()) {
case INT:
int[][] intValuesMV = transformToIntValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
int[] intValues = intValuesMV[i];
int numValues = intValues.length;
double[] doubleValues = new double[numValues];
ArrayCopyUtils.copy(intValues, doubleValues, numValues);
_doubleValuesMV[i] = doubleValues;
}
ArrayCopyUtils.copy(intValuesMV, _doubleValuesMV, length);
break;
case LONG:
long[][] longValuesMV = transformToLongValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
long[] longValues = longValuesMV[i];
int numValues = longValues.length;
double[] doubleValues = new double[numValues];
ArrayCopyUtils.copy(longValues, doubleValues, numValues);
_doubleValuesMV[i] = doubleValues;
}
ArrayCopyUtils.copy(longValuesMV, _doubleValuesMV, length);
break;
case FLOAT:
float[][] floatValuesMV = transformToFloatValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
float[] floatValues = floatValuesMV[i];
int numValues = floatValues.length;
double[] doubleValues = new double[numValues];
ArrayCopyUtils.copy(floatValues, doubleValues, numValues);
_doubleValuesMV[i] = doubleValues;
}
ArrayCopyUtils.copy(floatValuesMV, _doubleValuesMV, length);
break;
case STRING:
String[][] stringValuesMV = transformToStringValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
String[] stringValues = stringValuesMV[i];
int numValues = stringValues.length;
double[] doubleValues = new double[numValues];
ArrayCopyUtils.copy(stringValues, doubleValues, numValues);
_doubleValuesMV[i] = doubleValues;
}
ArrayCopyUtils.copy(stringValuesMV, _doubleValuesMV, length);
break;
default:
throw new IllegalStateException();
Expand Down Expand Up @@ -682,67 +582,27 @@ public String[][] transformToStringValuesMV(ProjectionBlock projectionBlock) {
switch (dataType) {
case INT:
int[][] intValuesMV = transformToIntValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
int[] intValues = intValuesMV[i];
int numValues = intValues.length;
String[] stringValues = new String[numValues];
ArrayCopyUtils.copy(intValues, stringValues, numValues);
_stringValuesMV[i] = stringValues;
}
ArrayCopyUtils.copy(intValuesMV, _stringValuesMV, length);
break;
case LONG:
long[][] longValuesMV = transformToLongValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
long[] longValues = longValuesMV[i];
int numValues = longValues.length;
String[] stringValues = new String[numValues];
ArrayCopyUtils.copy(longValues, stringValues, numValues);
_stringValuesMV[i] = stringValues;
}
ArrayCopyUtils.copy(longValuesMV, _stringValuesMV, length);
break;
case FLOAT:
float[][] floatValuesMV = transformToFloatValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
float[] floatValues = floatValuesMV[i];
int numValues = floatValues.length;
String[] stringValues = new String[numValues];
ArrayCopyUtils.copy(floatValues, stringValues, numValues);
_stringValuesMV[i] = stringValues;
}
ArrayCopyUtils.copy(floatValuesMV, _stringValuesMV, length);
break;
case DOUBLE:
double[][] doubleValuesMV = transformToDoubleValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
double[] doubleValues = doubleValuesMV[i];
int numValues = doubleValues.length;
String[] stringValues = new String[numValues];
ArrayCopyUtils.copy(doubleValues, stringValues, numValues);
_stringValuesMV[i] = stringValues;
}
ArrayCopyUtils.copy(doubleValuesMV, _stringValuesMV, length);
break;
case BOOLEAN:
intValuesMV = transformToIntValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
int[] intValues = intValuesMV[i];
int numValues = intValues.length;
String[] stringValues = new String[numValues];
for (int j = 0; j < numValues; j++) {
stringValues[j] = Boolean.toString(intValues[i] == 1);
}
_stringValuesMV[i] = stringValues;
}
ArrayCopyUtils.copyBoolean(intValuesMV, _stringValuesMV, length);
break;
case TIMESTAMP:
longValuesMV = transformToLongValuesMV(projectionBlock);
for (int i = 0; i < length; i++) {
long[] longValues = longValuesMV[i];
int numValues = longValues.length;
String[] stringValues = new String[numValues];
for (int j = 0; j < numValues; j++) {
stringValues[j] = new Timestamp(longValues[i]).toString();
}
_stringValuesMV[i] = stringValues;
}
ArrayCopyUtils.copyTimestamp(longValuesMV, _stringValuesMV, length);
break;
default:
throw new IllegalStateException();
Expand Down