[Code Refactor] ArrayCopyUtils 2D Array for Transform Functions#9324
Merged
siddharthteotia merged 3 commits intoapache:masterfrom Sep 6, 2022
Merged
[Code Refactor] ArrayCopyUtils 2D Array for Transform Functions#9324siddharthteotia merged 3 commits intoapache:masterfrom
siddharthteotia merged 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9324 +/- ##
=============================================
- Coverage 69.73% 28.44% -41.30%
+ Complexity 4772 53 -4719
=============================================
Files 1873 1863 -10
Lines 99616 99393 -223
Branches 15168 15128 -40
=============================================
- Hits 69471 28276 -41195
- Misses 25210 68385 +43175
+ Partials 4935 2732 -2203
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
somandal
approved these changes
Sep 6, 2022
Contributor
somandal
left a comment
somandal
left a comment
There was a problem hiding this comment.
lgtm, thanks for the cleanup!
siddharthteotia
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactored code in
BaseTransformFunctionto use the newly added helper functions inArrayCopyUtils.Related PR: #9296