Allow server to directly return the final aggregation result#9304
Merged
siddharthteotia merged 1 commit intoapache:masterfrom Sep 7, 2022
Merged
Allow server to directly return the final aggregation result#9304siddharthteotia merged 1 commit intoapache:masterfrom
siddharthteotia merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9304 +/- ##
============================================
- Coverage 69.77% 69.73% -0.05%
- Complexity 4692 4771 +79
============================================
Files 1873 1874 +1
Lines 99570 99706 +136
Branches 15160 15185 +25
============================================
+ Hits 69477 69526 +49
- Misses 25156 25247 +91
+ Partials 4937 4933 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
siddharthteotia
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is only one server queried, we can calculate the final aggregation result on the server side, instead of serializing back the intermediate result (which can be huge for distinct_count, percentile etc.).
This PR adds a new query option
serverReturnFinalResultto let the server directly return the final aggregation result. As a follow up, we may add a flag to the broker config to let the broker automatically add this query option when it is querying only one server.