Adding logger utils and allow change logger level at runtime#9180
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Aug 9, 2022
Merged
Adding logger utils and allow change logger level at runtime#9180xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0 merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9180 +/- ##
=============================================
+ Coverage 28.49% 69.98% +41.48%
- Complexity 53 4756 +4703
=============================================
Files 1836 1852 +16
Lines 98103 98760 +657
Branches 14897 15021 +124
=============================================
+ Hits 27956 69113 +41157
+ Misses 67460 24773 -42687
- Partials 2687 4874 +2187
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
201b3b9 to
c6e0180
Compare
c7b817b to
ba45cf2
Compare
Jackie-Jiang
reviewed
Aug 8, 2022
Contributor
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Can you please add some tests for the LoggerUtils?
We want to test the following things:
- The expected return for each method
- Whether the already initialized logger can be updated
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
walterddr
reviewed
Aug 8, 2022
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
kkrugler
reviewed
Aug 8, 2022
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
kkrugler
reviewed
Aug 8, 2022
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
kkrugler
reviewed
Aug 8, 2022
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
c3094a5 to
70dd3c6
Compare
Jackie-Jiang
reviewed
Aug 9, 2022
pinot-common/src/test/java/org/apache/pinot/common/utils/LoggerUtilsTest.java
Outdated
Show resolved
Hide resolved
pinot-common/src/test/java/org/apache/pinot/common/utils/LoggerUtilsTest.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
b9e98fb to
7228fa2
Compare
Jackie-Jiang
approved these changes
Aug 9, 2022
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/LoggerUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/test/java/org/apache/pinot/common/utils/LoggerUtilsTest.java
Outdated
Show resolved
Hide resolved
7228fa2 to
c5bdf14
Compare
c5bdf14 to
5395c67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow change logger level at runtime.
APIs:
Sample usage: