Allow dynamically setting the log level even for loggers that aren't already explicitly configured#13156
Merged
xiangfu0 merged 2 commits intoapache:masterfrom May 16, 2024
Merged
Conversation
…already explicitly configured
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13156 +/- ##
============================================
+ Coverage 61.75% 62.15% +0.40%
+ Complexity 207 198 -9
============================================
Files 2436 2515 +79
Lines 133233 137871 +4638
Branches 20636 21337 +701
============================================
+ Hits 82274 85692 +3418
- Misses 44911 45779 +868
- Partials 6048 6400 +352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8498647 to
c3356b3
Compare
xiangfu0
approved these changes
May 15, 2024
gortiz
pushed a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
…already explicitly configured (apache#13156) * Allow dynamically setting the log level even for loggers that aren't already explicitly configured * Allow dynamically configuring log levels for ancestor / parent loggers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root,org.apache.pinot.tools.adminandorg.reflections(see this log4j config file for reference).org.apache.pinot.controller.helix.core.realtime.SegmentCompletionManagerclass viaPUT /loggers/org.apache.pinot.controller.helix.core.realtime.SegmentCompletionManager?level=DEBUG, this returns the following response:{"code":500,"error":"Logger - org.apache.pinot.controller.helix.core.realtime.SegmentCompletionManager not found"}In a future enhancement, we could also allow dynamically setting the log level for an ancestor logger which would affect all the descendant loggers (see https://logging.apache.org/log4j/2.x/manual/architecture.html#logger-hierarchy).org.apache.pinot.controller.helix.core. This will then also affect the log level for all the descendant / child loggers - for instance,org.apache.pinot.controller.helix.core.realtime.SegmentCompletionManager(see https://logging.apache.org/log4j/2.x/manual/architecture.html#logger-hierarchy).bugfixorfeature