allow mvn build with development webpack; fix instances default value#9179
Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom Aug 9, 2022
jadami10:jadami/fix-instance-key-get
Merged
allow mvn build with development webpack; fix instances default value#9179Jackie-Jiang merged 2 commits intoapache:masterfrom jadami10:jadami/fix-instance-key-get
Jackie-Jiang merged 2 commits intoapache:masterfrom
jadami10:jadami/fix-instance-key-get
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9179 +/- ##
============================================
+ Coverage 69.90% 69.93% +0.02%
+ Complexity 5003 4758 -245
============================================
Files 1847 1847
Lines 98562 98684 +122
Branches 14970 15007 +37
============================================
+ Hits 68900 69014 +114
+ Misses 24821 24818 -3
- Partials 4841 4852 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Jackie-Jiang
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is
uiandbugfixbuildThis was tested by building pinot-controller in IntelliJ with the new
npm.scriptoption set to build-dev. The ui ran with non-minified code in main.js. Then I ran realtime Quickstart to ensure the/instancesworked correctly.