#8970 Minion tab in Pinot UI

[satishwaghela]

Closes: #8970

Release notes:
Minion UI tab

[npawar]

Thanks @satishwaghela ! Just played around with this and it's pretty neat! Here's some suggestions:

1. On Homepage, Move MINIONS after SERVERS (Order of these tables should be Controllers, Brokers, Servers, Minions)

2. Is this validation coming from UI or backend? If UI, no need for this restriction in tags for Minions, it can be anything.

3. After editing the tag for Minion, I see this table appear below, which should not be there

4. Replace Execution Time with “Elapsed Time”. Calculate the value using System.currentTimeMillis() - startTime. Show value in minutes if < 60. In hours + minutes if > 60

5. After clicking Schedule Now, show a modal with message “Are you sure you want to schedule this task?” If user clicks YES, then show the Task ID from the response as “ scheduled” and give user an option to dismiss the message

[npawar]

1. These buttons have different tooltip text provided in the design doc
2. Show every unique table name only once (in this case githubEvents_REALTIME should appear only once)
3. On this page, when clicking “Resume All” show similar modal to the one as used in “Stop All”. Same for Cleanup All.
4. After clicking “Stop All” immediately call the API to update “Task Queue Status” field (it should become STOPPED as per the API). Same for “Resume All”, call API to get updated status
5. After calling Stop or Resume, sometimes going back to homepage just keeps spinning

[npawar]

@joshigaurava @shahsank3t please help review from code perspective. Thanks!

[npawar]

Thanks @satishwaghela . I have last couple of comments

1. After scheduling task using “Schedule Now”, show different message as per response. If response contains null, show message “Could not schedule task for ”. If response contains a task id, show the Task ID from the response as “ scheduled” and give user an option to dismiss the message (dont auto disappear)
2. From this page (http://localhost:9000/#/task-queue/MergeRollupTask/tables/githubEvents_OFFLINE) if i click refresh on browser, I see it takes 10-15 seconds to load.
3. The Start Time is empty for on UI for a task with status IN_PROGRESS, but if I inspect the response, I do see the startTime field.
   

[joshigaurava]

Is it feasible to declare these as enums/constants?

[npawar]

Still seeing high load time when I refresh this page. Seems to be coming from "info" call?

[npawar]

also, please take a look at why the Pinot Integration Test fails in the Github Actions. Seems to be throwing some exceptions from ui code

[npawar]

also, please take a look at why the Pinot Integration Test fails in the Github Actions. Seems to be throwing some exceptions from ui code

Seeing this : https://github.com/apache/pinot/runs/7293911715?check_suite_focus=true

 ERROR in /home/runner/work/pinot/pinot/pinot-controller/src/main/resources/app/pages/TaskQueueTable.tsx
[INFO] ./app/pages/TaskQueueTable.tsx
[INFO] [tsl] ERROR in /home/runner/work/pinot/pinot/pinot-controller/src/main/resources/app/pages/TaskQueueTable.tsx(31,31)
[INFO]       TS2307: Cannot find module '../components/useMinionMetadata'.
[INFO] Child HtmlWebpackCompiler:
[INFO]      1 asset
[INFO]     Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
[INFO]     [0] ./node_modules/html-webpack-plugin/lib/loader.js!./app/index.html 1.43 KiB {0} [built]
[INFO] npm ERR! code ELIFECYCLE
[INFO] npm ERR! errno 2
[INFO] npm ERR! pinot-controller-ui@1.0.0 build: `webpack --mode production`
[INFO] npm ERR! Exit status 2
[INFO] npm ERR! 
[INFO] npm ERR! Failed at the pinot-controller-ui@1.0.0 build script.
[INFO] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

[codecov-commenter]

Codecov Report

Merging #8978 (486dd34) into master (c802786) will increase coverage by 0.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8978      +/-   ##
============================================
+ Coverage     69.78%   69.99%   +0.20%     
- Complexity     4679     4736      +57     
============================================
  Files          1808     1831      +23     
  Lines         94235    96239    +2004     
  Branches      14052    14381     +329     
============================================
+ Hits          65765    67362    +1597     
- Misses        23908    24225     +317     
- Partials       4562     4652      +90     

Flag	Coverage Δ
integration1	26.41% <ø> (-0.29%)	⬇️
integration2	24.63% <ø> (-0.25%)	⬇️
unittests1	66.85% <ø> (+0.45%)	⬆️
unittests2	15.40% <ø> (+0.51%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...data/manager/realtime/DefaultSegmentCommitter.java	0.00% <0.00%> (-80.00%)	⬇️
...lanner/partitioning/FieldSelectionKeySelector.java	45.83% <0.00%> (-39.89%)	⬇️
...che/pinot/plugin/stream/kinesis/KinesisConfig.java	65.62% <0.00%> (-34.38%)	⬇️
...core/operator/filter/predicate/PredicateUtils.java	74.07% <0.00%> (-25.93%)	⬇️
.../readers/forward/FixedBitMVForwardIndexReader.java	73.49% <0.00%> (-24.34%)	⬇️
...e/impl/forward/FixedByteMVMutableForwardIndex.java	70.78% <0.00%> (-23.16%)	⬇️
...t/segment/spi/index/reader/ForwardIndexReader.java	46.86% <0.00%> (-22.74%)	⬇️
...ller/helix/core/minion/TaskTypeMetricsUpdater.java	80.00% <0.00%> (-20.00%)	⬇️
...er/api/resources/LLCSegmentCompletionHandlers.java	43.56% <0.00%> (-18.82%)	⬇️
...in/java/org/apache/pinot/spi/utils/StringUtil.java	81.81% <0.00%> (-18.19%)	⬇️
... and 257 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c802786...486dd34. Read the comment docs.

[joshigaurava]

Looks good!

[npawar]

Lgtm functionally!

[npawar]

@klsince i'll merge this for now. if you do have any feedback after you play with it, we can address those separately