Enable range index on raw columns and push counts down to range index when v2 is in use #8513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8513 +/- ##
============================================
- Coverage 70.59% 69.34% -1.25%
- Complexity 4227 4292 +65
============================================
Files 1674 1675 +1
Lines 87618 87664 +46
Branches 13272 13279 +7
============================================
- Hits 61852 60792 -1060
- Misses 21477 22607 +1130
+ Partials 4289 4265 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
richardstartin
force-pushed
the
range-count
branch
from
49fed85 to
c2a457a
Compare
walterddr
reviewed
Apr 14, 2022
...-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java
Outdated
Show resolved
Hide resolved
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/RangeIndexReader.java
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Apr 18, 2022
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/RangeIndexReader.java
Show resolved
Hide resolved
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/RangeIndexReader.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/pinot/segment/local/segment/index/creator/BitSlicedIndexCreatorTest.java
Show resolved
Hide resolved
...-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java
Outdated
Show resolved
Hide resolved
richardstartin
force-pushed
the
range-count
branch
from
c2a457a to
f30099e
Compare
richardstartin
changed the title
|
@Jackie-Jiang the copy-paste bug you spotted was revealing - range indexes over raw columns was not actually supported, despite #5853 aiming to add support. Commit fe28919 addresses that. Commit f30099e addresses your review comments, and adds a test to verify the bug is fixed (and that the code executes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the fast count mechanism to v2 range indexes now that the underlying data structure supports counting. Also does some code cleanup in this area.