Add Range Indexing support for raw values #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishoreg
reviewed
Aug 14, 2020
...rc/main/java/org/apache/pinot/core/segment/index/loader/invertedindex/RangeIndexHandler.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pinot/core/segment/creator/DictionaryBasedInvertedIndexCreator.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/pinot/core/segment/index/loader/invertedindex/RangeIndexHandler.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Aug 26, 2020
| switch (_rangePredicateEvaluator.getDataType()) { | ||
| case INT: { | ||
| firstRangeId = rangeIndexReader.findRangeId(((IntRawValueBasedRangePredicateEvaluator) _rangePredicateEvaluator).geLowerBound()); | ||
| lastRangeId = rangeIndexReader.findRangeId(((RangePredicateEvaluatorFactory.IntRawValueBasedRangePredicateEvaluator) _rangePredicateEvaluator).getUpperBound()); |
There was a problem hiding this comment.
Suggested change
| lastRangeId = rangeIndexReader.findRangeId(((RangePredicateEvaluatorFactory.IntRawValueBasedRangePredicateEvaluator) _rangePredicateEvaluator).getUpperBound()); | |
| lastRangeId = rangeIndexReader.findRangeId(((IntRawValueBasedRangePredicateEvaluator) _rangePredicateEvaluator).getUpperBound()); |
| @@ -82,8 +82,8 @@ | |||
| private Map<String, ColumnIndexCreationInfo> indexCreationInfoMap; | |||
| private Map<String, SegmentDictionaryCreator> _dictionaryCreatorMap = new HashMap<>(); | |||
| private Map<String, ForwardIndexCreator> _forwardIndexCreatorMap = new HashMap<>(); | |||
| private Map<String, InvertedIndexCreator> _invertedIndexCreatorMap = new HashMap<>(); | |||
| private Map<String, InvertedIndexCreator> _textIndexCreatorMap = new HashMap<>(); | |||
| private Map<String, DictionaryBasedInvertedIndexCreator> _dictionaryBasedInvertedIndexCreatorMap = new HashMap<>(); | |||
There was a problem hiding this comment.
Suggest not changing the variable name. We'll probably use the same map for raw index based inverted index in the future once supported
| @@ -45,7 +46,7 @@ | |||
|
|
|||
|
|
|||
| /** | |||
| * Implementation of {@link InvertedIndexCreator} that uses off-heap memory. | |||
| * Implementation of {@link DictionaryBasedInvertedIndexCreator} that uses off-heap memory. | |||
| @@ -65,7 +66,7 @@ | |||
| * </li> | |||
| * </ul> | |||
| */ | |||
| public final class RangeIndexCreator implements InvertedIndexCreator { | |||
| public final class RangeIndexCreator implements RawValueBasedInvertedIndexCreator,DictionaryBasedInvertedIndexCreator { | |||
| @@ -18,16 +18,18 @@ | |||
| */ | |||
| package org.apache.pinot.core.segment.index.creator; | |||
|
|
|||
| import com.google.common.base.Preconditions; | |||
|
|
|||
There was a problem hiding this comment.
Please reformat this file, the indentation is not correct
kishoreg
approved these changes
Aug 29, 2020
Jackie-Jiang
force-pushed
the
range_indexing_patch
branch
from
e70814f to
8f26ef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #5703
Following refactoring has been done in this PR