Add test coverage for consuming segment using on-heap memory.#8385
Add test coverage for consuming segment using on-heap memory.#8385Jackie-Jiang merged 1 commit intoapache:masterfrom
Conversation
|
Can you add the appropriate labels for release notes please? thanks |
The original PR that did the config value change has all the labels and release notes. This one is just making sure we have coverage for non-default. |
Codecov Report
@@ Coverage Diff @@
## master #8385 +/- ##
=============================================
- Coverage 69.75% 37.78% -31.97%
+ Complexity 4212 84 -4128
=============================================
Files 1653 1654 +1
Lines 86615 86452 -163
Branches 13080 13037 -43
=============================================
- Hits 60420 32668 -27752
- Misses 21966 51185 +29219
+ Partials 4229 2599 -1630
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
With PR apache#8380, we modified the default value for `pinot.server.instance.realtime.alloc.offheap` to use off-heap. Explicitly setting it to use on-heap in some of the integration tests for coverage.
Description
With PR #8380, we modified the default value for
pinot.server.instance.realtime.alloc.offheapto use off-heap. Explicitly settingit to use on-heap in some of the integration tests for coverage.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation