Cmd+enter shortcut to run query in Pinot data explorer query console #7359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Description* Add a shortcut (Cmd + Enter) that can be used to run the query when you are focused on the code editor in the pinot controller query console. Cmd + Enter is pretty standard in query application tools I've used before. Just a nice to have and makes running queries feel a bit easier.
priyen
added a commit
to priyen/pinot-docs
that referenced
this pull request
Aug 24, 2021
Just adding docs about the cmd + enter shortcut I want to add as part of apache/pinot#7359
Codecov Report
@@ Coverage Diff @@
## master #7359 +/- ##
=============================================
- Coverage 71.65% 30.33% -41.32%
+ Complexity 3305 87 -3218
=============================================
Files 1515 1506 -9
Lines 74992 74644 -348
Branches 10903 10865 -38
=============================================
- Hits 53736 22645 -31091
- Misses 17629 49992 +32363
+ Partials 3627 2007 -1620
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jackjlli
approved these changes
Aug 25, 2021
|
Thanks @jackjlli - can you merge this in? (and also look at the documentation PR pinot-contrib/pinot-docs#58 if you have time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a shortcut (Cmd + Enter) that can be used to run the query when you are focused on the code editor in the pinot controller query console.
Cmd + Enter is pretty standard in query application tools I've used before.
Just a nice to have and makes running queries feel a bit easier.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
No
Does this PR fix a zero-downtime upgrade introduced earlier?
No
Does this PR otherwise need attention when creating release notes? Things to consider:
No
Release Notes
n/a
-->
Documentation
pinot-contrib/pinot-docs#58