[UI] Adds support for CTRL key as a modifier for Query shortcuts #12087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a simple UI enhancement, adding support for the CTRL key as a modifier on the Query page (for Windows and Linux users).
The feature was originally added on #7359, but only included support for the
event.metaKey
modifier, which maps to the ⌘ key on MacOS, but really can't be used as a modifier for Windows/Linux users.pinot/pinot-controller/src/main/resources/app/pages/Query.tsx
Lines 216 to 225 in 949083d
With the implementation on this PR, MacOS users could use either the Cmd (⌘) or Control (^) as modifiers.
Closes #12086