Validate timeColumnName when adding/updating schema/tableConfig

[npawar]

Description

#5915
Add validation to check that timeColumnName is in sync across the table config and schema.

Cases

• Adding/updating tableConfig - Find associated schema (using rawTableName or from validationConfig.getSchemaName). Check that timeColumnName is present in schema. For OFFLINE, it is possible that timeColumnName/schema is null.
• Adding/updating schema - Find associated table configs (schemaName_OFFLINE and schemaName_REALTIME) Check timeColumnName used in all associated tableConfigs also exists in schema.

Corner case
If tableConfig has been created with a schemaName != rawTableName, then we will not be able to validate during schema add/upload.

Release Notes

After this change,

1. uploading a tableConfig with timeColumnName not present in schema will be disallowed (provided schema already uploaded)
2. uploading schema with timeColumnName not present in the schema will be disallowed (provided schemaName = tableName)

[mcvsubbu]

We do allow to have tables without a schema. I have not had the time to go through this fully, but do you account for the fact that a (offline) table may not have a schema at all?

[npawar]

We do allow to have tables without a schema. I have not had the time to go through this fully, but do you account for the fact that a (offline) table may not have a schema at all?

Yes, I have accounted for offline table not having schema at all. I've put in the description all the cases it covers, and the case we miss out

[icefury71]

Minor comments

[icefury71]

nit: wrap with try-catch for future proofing ?

[npawar]

do you mean a case where the schema becomes invalid, but we pass the test anyway because of not having a try-catch?
Just to be sure, I tried this out. The test fails if there's any exception in the should-pass cases.
Lmk if you were referring to something else.

[icefury71]

I meant catching exception and explicitly 'fail'ing. It's fine though - just a nit.

[icefury71]

Same here

[Jackie-Jiang]

LGTM with minor comments