Skip to content

Ensure time-column compatibility between schema and tableconfig #5915

Closed
@mcvsubbu

Description

We need to check the following when a tableConfig is added or updated, or when a schema is updated:

The time column name (and type) in the tableConfig is the same as the primary time column name and type in the schema. The schema may not exist, in which case it is ok (we currently allow creating offline tables without a schema). The schema could be under the default (recommended) name -- the table name, or it could be under a different name indicate in the table config. The time column in the schema could either be TimeFieldSpec or DateTimeFieldSpec

Similarly, when updating (or adding) a schema, we should make sure that the same consistency checks are done. A schema may be added after an offline table is added. Or, a schema may be updated. It is possible that there is no table corresponding to a schema (yet) since the table is yet to be created (we recommend creating schema first).

The only case we will miss out is if a (offline) table is created with a different schema name, and then schema is added later. We will leave this as a corner case.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions