Add config to set batchMessageMode on ideal state of new tables#3613
Merged
Add config to set batchMessageMode on ideal state of new tables#3613
Conversation
mcvsubbu
approved these changes
Dec 13, 2018
Codecov Report
@@ Coverage Diff @@
## master #3613 +/- ##
============================================
- Coverage 70.69% 70.66% -0.03%
Complexity 4 4
============================================
Files 1009 1009
Lines 46290 46294 +4
Branches 6208 6208
============================================
- Hits 32725 32714 -11
- Misses 11410 11427 +17
+ Partials 2155 2153 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per experiments in PINOT-7473 we enabled batchMessageMode for some tables and saw a reduction znode count during startup. This PR will allow newly created tables to have that setting enabled in the ideal state. The config is added as a controller config so that it can be disabled at the cluster level if need be.