Skip to content

Add config to set batchMessageMode on ideal state of new tables#3613

Merged
npawar merged 1 commit intomasterfrom
batch_update_mode
Dec 13, 2018
Merged

Add config to set batchMessageMode on ideal state of new tables#3613
npawar merged 1 commit intomasterfrom
batch_update_mode

Conversation

@npawar
Copy link
Contributor

@npawar npawar commented Dec 13, 2018

As per experiments in PINOT-7473 we enabled batchMessageMode for some tables and saw a reduction znode count during startup. This PR will allow newly created tables to have that setting enabled in the ideal state. The config is added as a controller config so that it can be disabled at the cluster level if need be.

@codecov-io
Copy link

Codecov Report

Merging #3613 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3613      +/-   ##
============================================
- Coverage     70.69%   70.66%   -0.03%     
  Complexity        4        4              
============================================
  Files          1009     1009              
  Lines         46290    46294       +4     
  Branches       6208     6208              
============================================
- Hits          32725    32714      -11     
- Misses        11410    11427      +17     
+ Partials       2155     2153       -2
Impacted Files Coverage Δ Complexity Δ
...ot/controller/helix/core/util/HelixSetupUtils.java 63.76% <100%> (-0.52%) 0 <0> (ø)
.../com/linkedin/pinot/controller/ControllerConf.java 43.79% <100%> (+0.36%) 0 <0> (ø) ⬇️
...roller/helix/core/PinotTableIdealStateBuilder.java 80.89% <100%> (+0.66%) 0 <0> (ø) ⬇️
...ntroller/helix/core/PinotHelixResourceManager.java 59.79% <100%> (-0.07%) 0 <0> (ø)
...in/pinot/core/query/pruner/ValidSegmentPruner.java 57.14% <0%> (-28.58%) 0% <0%> (ø)
...impl/dictionary/DoubleOnHeapMutableDictionary.java 68.88% <0%> (-13.34%) 0% <0%> (ø)
...elix/core/relocation/RealtimeSegmentRelocator.java 68.75% <0%> (-11.46%) 0% <0%> (ø)
...kedin/pinot/core/util/SortedRangeIntersection.java 83.82% <0%> (-7.36%) 0% <0%> (ø)
...mpl/dictionary/DoubleOffHeapMutableDictionary.java 70.9% <0%> (-7.28%) 0% <0%> (ø)
...inkedin/pinot/common/config/RealtimeTagConfig.java 93.33% <0%> (-6.67%) 0% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d48e4fd...b15bac7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants