Skip to content

Improve segment build auto retry logics #16663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenboat merged 1 commit into from
Aug 25, 2025
Merged

Improve segment build auto retry logics #16663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.io.File;
import java.io.IOException;
import java.net.URISyntaxException;
import java.nio.BufferOverflowException;
import java.time.Duration;
import java.time.Instant;
import java.util.ArrayList;
Expand Down Expand Up @@ -1161,8 +1162,8 @@ protected SegmentBuildDescriptor buildSegmentInternal(boolean forCommit)
} catch (Exception e) {
String errorMessage = "Could not build segment";
FileUtils.deleteQuietly(tempSegmentFolder);
if (e instanceof IllegalStateException) {
// Precondition checks fail, the segment build would fail consistently
if (e instanceof IllegalStateException || e instanceof BufferOverflowException) {
// Index or forward index too large issue, the segment build would fail consistently
_segmentBuildFailedWithDeterministicError = true;
}
reportSegmentBuildFailure(errorMessage, e);
Expand Down
Loading