Reduce log verbosity for PerQueryCPUMemResourceUsageAccountant

[Jackie-Jiang]

Summary

This PR reduces excessive logging in the PerQueryCPUMemResourceUsageAccountant class to improve performance and reduce log noise in production environments. The changes focus on converting verbose WARN-level logs to DEBUG-level logs while maintaining essential error information.

Changes Made

🔧 Core Improvements

• Reduced log verbosity: Changed several WARN-level logs to DEBUG-level to reduce log noise
• Improved thread safety: Replaced HashSet with ConcurrentHashMap.newKeySet() for _cancelSentQueries
• Enhanced error handling: Improved interrupt handling in the WatcherTask run loop
• Code cleanup: Removed unused parameters and improved code structure

📝 Specific Changes

1. Logging Level Changes:

   • logQueryResourceUsage(): WARN → DEBUG for query aggregation results
   • logSelfTerminatedQuery(): Improved logic and formatting
   • triggeredActions(): WARN → DEBUG for alarming level verbose logging
   • Various query termination logs: Improved formatting and clarity

2. Thread Safety Improvements:

   • Replaced HashSet with ConcurrentHashMap.newKeySet() for better concurrency
   • Improved interrupt handling in WatcherTask.run()

3. Code Structure:

   • Removed unused isThreadSamplingEnabledForMSE parameter
   • Added @VisibleForTesting annotation for test methods
   • Made TriggeringLevel enum protected for better encapsulation
   • Improved trigger evaluation logic with better state management

4. Test Updates:

   • Updated test classes to match new constructor signatures
   • Removed excessive log4j configuration from integration tests
   • Updated assertion messages to match new log formats

🧪 Files Modified

• PerQueryCPUMemAccountantFactory.java - Main changes to reduce logging and improve thread safety
• QueryAggregator.java - Updated documentation
• TestResourceAccountant.java - Updated constructor call
• Integration test files - Removed excessive logging setup and updated assertions

Impact

• Performance: Reduced log I/O overhead in production environments
• Maintainability: Cleaner code structure with better separation of concerns
• Debugging: Essential error information is still logged at appropriate levels
• Thread Safety: Improved concurrency handling for query cancellation tracking

Testing

• All existing integration tests pass with updated assertions
• Thread safety improvements tested through existing concurrent test scenarios
• Log level changes verified to maintain essential debugging information

[Copilot]

Pull Request Overview

This PR reduces excessive logging in the PerQueryCPUMemResourceUsageAccountant class to improve performance and reduce log noise in production environments. The changes focus on converting verbose WARN-level logs to DEBUG-level logs while maintaining essential error information.

• Converted multiple WARN-level logs to DEBUG-level to reduce log verbosity
• Improved thread safety by replacing HashSet with ConcurrentHashMap.newKeySet() for concurrent access
• Enhanced error handling and code structure with better encapsulation and cleaner logic

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

File	Description
PerQueryCPUMemAccountantFactory.java	Main changes to reduce logging verbosity, improve thread safety, and enhance code structure
QueryAggregator.java	Updated documentation comment
TestResourceAccountant.java	Updated constructor call to match new signature
Integration test files	Removed excessive log4j configuration and updated test assertions to match new log formats

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}