Remove unnecessary methods and config for ThreadResourceUsageAccountant

[vrajat]

Remove:

• Tracing.ThreadAccountantOps.initializeThreadAccountant
• Tracing.ThreadAccountatOps.sampleMSE and related functions and tests. MSE operators now use the the sample method

[Copilot]

Pull Request Overview

This PR removes unnecessary methods and configuration related to ThreadResourceUsageAccountant for Multi-Stage Engine (MSE) queries. The main purpose is to simplify the codebase by consolidating MSE sampling to use the standard sample() method instead of the dedicated sampleMSE() method.

• Removes the sampleUsageMSE() method and related MSE-specific sampling configuration
• Removes the initializeThreadAccountant() method in favor of the existing createThreadAccountant()
• Updates MSE operators to use the standard sample() method instead of sampleMSE()

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
ThreadResourceUsageAccountant.java	Removes sampleUsageMSE() method declaration from interface
CommonConstants.java	Removes MSE-specific sampling configuration constants
Tracing.java	Removes initializeThreadAccountant() method and sampleUsageMSE() implementation
ResourceUsageAccountantFactory.java	Removes MSE-specific sampling logic and configuration
PerQueryCPUMemAccountantFactory.java	Removes MSE-specific sampling implementation and configuration
MultiStageOperator.java	Updates to use standard sample() method instead of sampleMSE()
MultistageResourceUsageAccountingTest.java	Updates to use createThreadAccountant() instead of initializeThreadAccountant()
MultiStageAccountingTest.java	Updates to use createThreadAccountant() instead of initializeThreadAccountant()
PerQueryCPUMemAccountantTest.java	Removes tests for MSE-specific sampling configuration and imports
ThrottleOnCriticalHeapUsageExecutorTest.java	Removes sampleUsageMSE() method implementation from test mock

Comments suppressed due to low confidence (2)

pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:148

• The line is trying to assign isThreadSamplingEnabledForMSE parameter but the field _isThreadSamplingEnabledForMSE has been removed. This will cause a compilation error.

      _inactiveQuery = inactiveQuery;

pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:142

• The constructor parameter isThreadSamplingEnabledForMSE is still being used in the constructor signature but the corresponding field has been removed, which will cause compilation errors.

    protected PerQueryCPUMemResourceUsageAccountant(PinotConfiguration config, boolean isThreadCPUSamplingEnabled,

[vrajat]

@praveenc7

[vrajat]

The backward incompatible test is expected to fail. It has errors for the functions that have been removed.

E: There is at least one incompatibility: org.apache.pinot.spi.accounting.ThreadResourceUsageAccountant.sampleUsageMSE():METHOD_REMOVED,org.apache.pinot.spi.trace.Tracing$ThreadAccountantOps.initializeThreadAccountant(org.apache.pinot.spi.env.PinotConfiguration,java.lang.String,org.apache.pinot.spi.config.instance.InstanceType):METHOD_REMOVED,org.apache.pinot.spi.trace.Tracing$ThreadAccountantOps.sampleMSE():METHOD_REMOVED,org.apache.pinot.spi.utils.CommonConstants$Accounting.CONFIG_OF_ENABLE_THREAD_SAMPLING_MSE:FIELD_REMOVED,org.apache.pinot.spi.utils.CommonConstants$Accounting.DEFAULT_ENABLE_THREAD_SAMPLING_MSE:FIELD_REMOVED