Move package org.apache.calcite to org.apache.pinot.calcite#12837
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Apr 8, 2024
Merged
Move package org.apache.calcite to org.apache.pinot.calcite#12837Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang merged 1 commit intoapache:masterfrom
Conversation
Jackie-Jiang
force-pushed
the
move_planner_package
branch
from
fe53fc0 to
684deed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12837 +/- ##
============================================
+ Coverage 61.75% 62.08% +0.33%
+ Complexity 207 198 -9
============================================
Files 2436 2492 +56
Lines 133233 135951 +2718
Branches 20636 21036 +400
============================================
+ Hits 82274 84404 +2130
- Misses 44911 45308 +397
- Partials 6048 6239 +191
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
siddharthteotia
approved these changes
Apr 8, 2024
jackjlli
approved these changes
Apr 8, 2024
Jackie-Jiang
added
the
backward-incompat
Contributor
Author
|
This change is introducing backward incompatibility because we rely on class path during query plan ser/de, and |
This was referenced Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Pinot classes under package
org.apache.calcitetoorg.apache.pinot.calciteto avoid confusion