Skip to content

[multistage][cleanup] remove some unused rules #12052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walterddr merged 2 commits into from
Nov 29, 2023
Merged

[multistage][cleanup] remove some unused rules #12052

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
325f0c1
[cleanup] some unused rules
Nov 27, 2023
1e457a1
fix comments
Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotQueryRuleSets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,9 @@ private PinotQueryRuleSets() {
// push project through set operation
CoreRules.PROJECT_SET_OP_TRANSPOSE,

// aggregation and projection rules
CoreRules.AGGREGATE_PROJECT_PULL_UP_CONSTANTS,
// push a projection past a filter or vice versa
CoreRules.PROJECT_FILTER_TRANSPOSE, CoreRules.FILTER_PROJECT_TRANSPOSE,
// push a projection to the children of a join
// push all expressions to handle the time indicator correctly
// push a filter past a project
CoreRules.FILTER_PROJECT_TRANSPOSE,
// push parts of the join condition to its inputs
CoreRules.JOIN_CONDITION_PUSH,
// remove identity project
CoreRules.PROJECT_REMOVE,
Expand All @@ -64,14 +61,19 @@ private PinotQueryRuleSets() {
// push project through WINDOW
CoreRules.PROJECT_WINDOW_TRANSPOSE,

// TODO: Revisit and see if they can be replaced with CoreRules.PROJECT_REDUCE_EXPRESSIONS and
// CoreRules.FILTER_REDUCE_EXPRESSIONS
// literal rules
// TODO: Revisit and see if they can be replaced with
// CoreRules.PROJECT_REDUCE_EXPRESSIONS and
// CoreRules.FILTER_REDUCE_EXPRESSIONS
PinotEvaluateLiteralRule.Project.INSTANCE, PinotEvaluateLiteralRule.Filter.INSTANCE,

// sort join rules
// TODO: evaluate the SORT_JOIN_TRANSPOSE and SORT_JOIN_COPY rules

// join rules
CoreRules.JOIN_PUSH_EXPRESSIONS,

// join and semi-join rules
CoreRules.PROJECT_TO_SEMI_JOIN,
PinotAggregateToSemiJoinRule.INSTANCE,

Expand Down